Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move smart contract pallet maintenance #1789

Closed
wants to merge 9 commits into from
Closed

Conversation

aric0x02
Copy link

@aric0x02 aric0x02 commented Jun 6, 2023

Project Abstract

Move smart contract pallet RFPs.

This Project based in Pontem MVM pallet.Pontem sp-move-vm.
In order to implement Move smart contract Pallet.
We will migrate api,table extension,u256 functions from aptos into it.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @aric0x02:matrix.org (change the homeserver if you use a different one)

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2023

CLA assistant check
All committers have signed the CLA.

@keeganquigley
Copy link
Contributor

keeganquigley commented Jun 9, 2023

Thanks for the application @aric0x02 I will mark it as ready for review and ping the committee. I have also pinged my colleague who wrote the RFP; he will be back next week.

@keeganquigley keeganquigley added the ready for review The project is ready to be reviewed by the committee members. label Jun 9, 2023
@keeganquigley keeganquigley requested a review from Noc2 June 9, 2023 15:46
@aric0x02
Copy link
Author

Thanks for your review.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application. It would be interesting to learn more about your long-term plans for this project. Do you plan to deploy it as a parachain? Also, given that you already have very concrete deliveries, it might make more sense to leverage the regular grant application template for this project: https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md. Finally could clean up the application a little bit. For example, feel free to remove the unnecessary text or the link https://github.com/aric0x02

@Noc2 Noc2 added changes requested The team needs to clarify a few things first. and removed ready for review The project is ready to be reviewed by the committee members. labels Jun 12, 2023
@aric0x02
Copy link
Author

Thanks for your review.Yes .We plan to deploy it as a parachain after the development version is stable.
We will update the application asap.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aric0x02 looks good except for the total amount. Each milestone is asking for 10k, making the total 20k. Can you fix this to specify what you are asking for? Thanks!

@aric0x02
Copy link
Author

Thanks for your review. Fixed it.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update here. Could you provide a little bit more information regarding your long-term motivation and your future goals with the project? Feel free to also integrate this into the application itself. Currently besides your Github profiles there is almost none information about you and your project available, which is a little bit strange especially if you are aiming for a parachain slot.

@semuelle
Copy link
Member

pinging @aric0x02

@Noc2
Copy link
Collaborator

Noc2 commented Jul 3, 2023

I wanted to let you know that I'm closing this because of inactivity. Let me know if I should reopen it.

@Noc2 Noc2 closed this Jul 3, 2023
@aric0x02
Copy link
Author

Sorry for the long late reply. We updated the application.

@Noc2
Copy link
Collaborator

Noc2 commented Jul 15, 2023

You currently can not open the application since the PR is closed. Should we reopen the PR or do you want to create a new application?

@aric0x02
Copy link
Author

You help us reopen the PR.Thanks a lot.

@Noc2 Noc2 reopened this Jul 15, 2023
@Noc2
Copy link
Collaborator

Noc2 commented Jul 15, 2023

@aric0x02 I reopened it. Feel free to update the application.

@aric0x02
Copy link
Author

Thanks.I updated the application.

@keeganquigley
Copy link
Contributor

Thanks @aric0x02 I will mark the application as ready for review and ping the rest of the committee.

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jul 17, 2023
@aric0x02
Copy link
Author

Thanks for your review.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, but could you clarify your long-term goals with this project in a little bit more detail? You previously said that you are aiming for a parachain, but now you say you just want to maintain it "like openzeppelin". How do you plan to fund this work also what changed since your last reply?

@aric0x02
Copy link
Author

We will achieve three main things:

  1. We will improve and enhance the functions of the existing move smart contract pallet and sp-move-vm.Such as add table in milestone1 and ,add U256 in milestone2 of the application.We will add other native funciton in it to support to move smart contract development on move smart contract node on substrate.
    Deploying it as a parachain in the Rococo testnet is a step required for a certain stage of testing.
    Usually testing smart contracts or applications is mainly based on local move smart contract development node.
  2. We will implement Move smart contract development example.
    It will implement common token standards, examples of move contracts such as DEFI, DAO, and governance, as well as the underlying support of contract modules that implement the basic storage structure required for them. we will extract common function as a library like openzeppelin.
  3. We will implement Move vscode IDE Plugin/Move playground.Committed to implement a simple, convenient editing, compiling, deploying, testing and development move smart contract environment.It will support deploying move smart contracts to the move smart contract node on substate.

I previously said that "We plan to deploy it as a parachain after the development version is stable." means
that when the Move smart contract example and the underlying built-in functions of sp-move-vm are relatively complete compared to aptos. We will deploy it as a parachain to the rococo testnet. It is the deliverable or result of a milestone in a certain phase. It can also be said to be an aim.

Each of our milestones is realized from the front-end web application, SDK, move smart contract pallet, virtual machine. Complete logic implementation.
we will focus on fully demonstrating the move smart contract pallet functionality and usage examples.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply. But again, what are your long-term plans with this? Given that we supported a team in the past that gave up and recently supported this team #1823, I'm personally unwilling to support another team unless there is a good reason for it and a clear roadmap.

@aric0x02
Copy link
Author

I see.I will close the application.Thanks

@aric0x02 aric0x02 closed this Jul 19, 2023
@takahser takahser removed the ready for review The project is ready to be reviewed by the committee members. label Jul 20, 2023
@Noc2 Noc2 mentioned this pull request Nov 7, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants