Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CosmWasmVM_CoreProduct-Milestone_1.md #999

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

JafarAz
Copy link
Contributor

@JafarAz JafarAz commented Sep 13, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1430

@JafarAz
Copy link
Contributor Author

JafarAz commented Sep 13, 2023

The author of the original grant application is no longer a team member of Composable, therefore, I will be submitting the milestones for this grant.

@keeganquigley
Copy link
Contributor

Update for transparency: Fixed Application Document in order to parse it correctly.

@keeganquigley keeganquigley mentioned this pull request Sep 13, 2023
10 tasks
@keeganquigley
Copy link
Contributor

Thanks @JafarAz someone will take a look at the delivery soon.

@dsm-w3f dsm-w3f self-assigned this Sep 14, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 15, 2023

@JafarAz thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. Let me know when I can continue this evaluation.

@JafarAz
Copy link
Contributor Author

JafarAz commented Sep 18, 2023

@dsm-w3f hi sir, I have updated the commands to install the ccw-vm and run a local network. It may take a while at first but once it's installed, you can come back to it almost instantly at a later time.

Is the CosmWasm CLI part of the deliverable of this milestone?

No it is a tool we developed for better developer experience, I guess it could have been a good part of the milestone but we did not include it at the time. Also, it is basic functionality right now, we intend to improve the cli in future iterations for better developer experiences.

Could you explain how to run the tests for the deliverable 1b?

Fuzzing tests can be run according to the official Rust docs for cargo-fuzz. Some precompiles that can be tested include:

1. XCM precompiles

  1. Pablo (PolkadotSDK DEX) precompiles

  2. Fuzzing test

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 19, 2023

@JafarAz thank you for the improvements and fixes. How long should the Fuzzing test take to finish? I'm waiting for some time them to finish but I don't know how long it would take or if should I just finish the process once this kind of test could not stop to run. What is the case here?

@JafarAz
Copy link
Contributor Author

JafarAz commented Sep 19, 2023

@dsm-w3f Fuzzing can go on for hours, likely infinite. If fuzzing will crash/exit with an error code - then it means that something has been found. For the test we linked, we ran it for half a day and nothing unusual showed up.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 20, 2023

@JafarAz thank you for the answer. I think now the milestone is ok, please see the evaluation document. The milestone is approved. I'll forward you invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 01e4862 into w3f:master Sep 20, 2023
3 checks passed
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@meldien
Copy link

meldien commented Sep 21, 2023

Hi @JafarAz
I noted on your invoice our recipient information is missing (Name, address, VAT number) and I'll missing the payment information as well.
Could you please update the invoice with the missing information?
Many thanks for your support.

@JafarAz
Copy link
Contributor Author

JafarAz commented Oct 9, 2023

@meldien hey, I resubmitted the invoice back when you messaged but I just noticed I forgot to reply. Lmk if there was any issue with the updated invoice

@semuelle
Copy link
Member

Hey @JafarAz. The invoice is missing the payment address. Please add this (the one from the application) to the invoice, so that there is no possible confusion about it. Thanks!

@JafarAz
Copy link
Contributor Author

JafarAz commented Oct 10, 2023

Got it, just resubmitted the invoice again. Apologies for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants