Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3F grant evidence submission #992

Merged
merged 31 commits into from
Sep 25, 2023
Merged

W3F grant evidence submission #992

merged 31 commits into from
Sep 25, 2023

Conversation

xcavate2022
Copy link
Contributor

@xcavate2022 xcavate2022 commented Sep 2, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1649

Xcavate-milestone_1.md Outdated Show resolved Hide resolved
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery, @xcavate2022. The pull request should only contain the delivery document, though. Could you move the other document and image elsewhere?

this file should not have been added here
@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 14, 2023 via email

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 14, 2023 via email

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 14, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 15, 2023

@xcavate2022 thank you for the improvements and fixes. I'm still having problems to test the system. Please see the evaluation document for details. Does not seem that all problems were fixed. Furthermore, it seems that some deliverables are still in development. Please let me know when all of them are ready to be evaluated again.

@meanking
Copy link

@dsm-w3f, thank you for your feedback.
Just I am curious about the problem you've faced for the wallet connection. The problem with the Backend is now solved. However, I still can't connect my wallet.
Could you detail about this, please? So, I can modify something or help you to run it successfully.

@RecrafterH
Copy link

@dsm-w3f hello, for the node we have an updated version on this repo: https://github.com/XcavateBlockchain/Xcavate_Node and for the smart contract the updated repo is this one: https://github.com/XcavateBlockchain/xcavate_loan_contract . Please use these repos for any further evaluation. Regarding the testing of the node and contract please use this polkadot js app site: https://polkadotjs-apps.web.app/#/accounts on the other one there seems to be an issue with uploading smart contracts. Thank you.

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 18, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 18, 2023

@xcavate2022 thank you for the improvements and fixes. I did a new round of evaluation but some problems remain. Please see the details in the evaluation document. Let me know when I can continue with this evaluation.

@RecrafterH
Copy link

@dsm-w3f sorry for didn't clarify this. You can build the contract by cd into the contracts/loan folder and call "cargo contract build --release". This works fine.

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 18, 2023 via email

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 19, 2023 via email

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 19, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 20, 2023

@xcavate2022 thank you for the answers and fixes. I still having some problems. Please see the evaluation document for details. Let me know when I can continue this evaluation.

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 20, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 21, 2023

@xcavate2022 thank you for the improvements and fixes. I still have some problems with the application but it could be related to the Acurast problem. The documentation still needs improvements. Please see the details in the evaluation document. Let me know when I can continue this evaluation.

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 22, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 22, 2023

@xcavate2022 thank you for the answer. How much discount you will give is up to you. We expect that to be proportional to the effort spent in the development of the deliverables that would be removed. The process is quite fast and consists of opening a PR changing the application document and explaining in the description of the PR the reason for the amendment. If you want to wait for Acurast to solve the problem is okay as well. Just let me know what you plan to do, and also when the docs are updated to check it again.

Amended documentation links
@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 24, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 25, 2023

@xcavate2022 after the amendment of the grant application, the remainder deliverables are working well. The milestone is accepted. Please submit the invoice reflecting the new price for the milestone. I'll forward it internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 2d91cbd into w3f:master Sep 25, 2023
3 checks passed
@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 25, 2023 via email

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Sep 25, 2023 via email

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Oct 4, 2023 via email

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 4, 2023

@xcavate2022 As you made an amendment to the application we need a new invoice with the adjusted value to be able to pay your team. Please send it using the same form that you used before for sending the invoice. After that, the payment processing time could take up to two weeks. Let me know when you submit the invoice to forward it internally.

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Oct 4, 2023 via email

@semuelle
Copy link
Member

semuelle commented Oct 5, 2023

Hi @xcavate2022. The payment address in the invoice does not match the one in the application. They need to be the same, so you have to either submit an invoice with the address from the application or submit an amendment PR to the contract with the address from the invoice.

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Oct 5, 2023 via email

@RouvenP
Copy link

RouvenP commented Oct 13, 2023

hi @xcavate2022 we transferred the payment today

@xcavate2022
Copy link
Contributor Author

xcavate2022 commented Oct 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants