Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tracking_chain-milestone_2.md #989

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

FedeC87p
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1915

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 1, 2023

@FedeC87p thank you for the milestone delivery. The application worked well but it is possible to improve some documentation and I had some doubts during the evaluation. Please see the evaluation document and provide proper answers and fixes. Let me know when I can continue this evaluation.

@FedeC87p
Copy link
Contributor Author

FedeC87p commented Sep 1, 2023

Hi, thanks for review, here are the answers below

Docker
Would be possible to create a docker that configures and run all the application?

I provided the Docker only for Sql server as it is the most invasive, while the other services are provided with the selfcontained packages of the dotnet framework. But if you need to test them I can also see to release a docker with a ready-to-use solution

Documentation and Testing Guide
Could you explain the Account ID and ProfileGroup ID and how to use the Admin tools?

Sorry, Account ID and ProfileGroup ID were not visible from the Admin tools, I already released a new version to fix this. Now they are visible in the Details section.

I also updated the page https://github.com/TrackingChains/TrackingChain/wiki/Milestone-2-Guide-to-Demo by adding the "FrontEnd Configuration" section, where there are two configuration examples (the most common ones and which in practice they cover the whole configuration). In that guide he shows how to use AccountId and how to configure new smartccontracts to be used.

I remain at your disposal for further details and clarifications.

@FedeC87p
Copy link
Contributor Author

FedeC87p commented Sep 4, 2023

Hi,

I just published a guide with instructions to be able to launch all services via docker https://github.com/TrackingChains/TrackingChain/wiki/Docker-Compose

The images are already configured with the test data and the configuration shown in the Step by Step guide.

With this I should have settled all the outstanding points and the review can continue @dsm-w3f .

Thank you

EDIT: I've added more details on the setup stage with a new section https://github.com/TrackingChains/TrackingChain/wiki#configuring-your-system-for-smart-contract-integration

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 5, 2023

@FedeC87p thank you for the improvements and fixes. I updated the evaluation document and now the milestone is accepted. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit fa2b7bd into w3f:master Sep 5, 2023
6 checks passed
@fededubbi
Copy link

Hi @FedeC87p,

I noticed that you used already in the past the same invoice number.
Could you please update the number for Milestone 2?

Many thanks,
Federica

@FedeC87p
Copy link
Contributor Author

FedeC87p commented Sep 6, 2023

Thanks for reporting @fededubbi , I just sent with the correct number

@RouvenP
Copy link

RouvenP commented Sep 11, 2023

hi @FedeC87p we just transferred the payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants