-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CILA first milestone #978
CILA first milestone #978
Conversation
@AlexShkor thank you for the milestone delivery and @BaranBayden for the external evaluation. The application look works for me. However, I'm getting the error below when I try to build the docker container. Could you please take a look? Would be nice to add to the documentation some instructions on how to build and run the application using docker as well. |
@dsm-w3f thank you for the review. May you please provide the local setup on your machine since it's building fine on my Mac M1 - probably just your CPU will be enough. |
@dsm-w3f we have added a documentation file run-docker.md to the root directory of the repository. We also added a possible fix for your EVN issue, hence we were not able to reproduce it locally |
@AlexShkor thank you for the improvements and fixes. I tried again and still not working. I'm receiving another error. See the image below. This is not supposed to be caused by running on Mac or Linux. Maybe clean up the docker image cache and try to build again you could reproduce the error. |
@dsm-w3f may you please try it now, I still was not able to reproduce the error, but just based on the screenshot you provided introduced some fixes - Could you please check if it works now? If it continues to not work, is there a possibility for us to finalize this milestone with this state of Dockerfile? To be honest, don't really know what else to try to reproduce the error you have |
@AlexShkor I tested again and I was able to build it. However, when I tried to connect with the container I was not possible to access it. Probably some port or export issue. As I was able to test the application without docker, I don't see a problem to approve it. The milestone is approved. I"ll forward your invoice internally and the payment should take place within two weeks. Great job! |
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion. |
Hi @AlexShkor, I noticed that on your invoice is missing the indication of VAT (this should be 0). Many thanks, |
Hi @fededubbi , sure |
@fededubbi I did resend the invoice, please check it out. Also it looks like that notification from this PR are not coming to me - maybe because it's closed |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1679 < please fill this in with the PR number of your application.