Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuma Wallet M4 #976

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Kuma Wallet M4 #976

merged 1 commit into from
Aug 25, 2023

Conversation

0xslipk
Copy link
Contributor

@0xslipk 0xslipk commented Aug 11, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1414

@dsm-w3f dsm-w3f self-assigned this Aug 16, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 16, 2023

@0xslipk thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. After that, let me know when I can continue this evaluation.

@0xslipk
Copy link
Contributor Author

0xslipk commented Aug 17, 2023

@0xslipk thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. After that, let me know when I can continue this evaluation.

Thank you for taking the time to review our delivery. We are gonna look the evaluation and address it

@0xslipk
Copy link
Contributor Author

0xslipk commented Aug 21, 2023

Hello @dsm-w3f,

We fixed all the issues reported. You can check the latest version v0.3.6.

Let me know if you have any question.

@rubenguc
Copy link

Hi @dsm-w3f, The problem with the transactions was that you needed to transfer more ASTR, because the fee in Acala has to be paid with ASTR.
Screenshot 2023-08-21 at 10 12 08 AM
Screenshot 2023-08-21 at 10 12 27 AM

For example, check out this transfer. It was transferred for 6 ASTR, and it has to pay around ~0.008 in ASTR as fee:

image

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 22, 2023

@0xslipk and @rubenguc thank you for the improvements and fixes. Look like most of the problems raised in the evaluation were fixed. However, I'm not able to use the wallet with Testnets yet. It would be possible to enable this? How did you test the application? We are not supposed to test applications using Mainnets.

@rubenguc
Copy link

@dsm-w3f you can enable them in Settings > General > Show testnets

Screenshot 2023-08-22 at 2 03 22 PM

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 23, 2023

@rubenguc thank you for the answer. Let me explain in more detail what is happening. The problem is not showing the testnet list, is when you select one of the testnets on the list, there is only the option to make XCM transfer to the same testnet. There is no option to make XCM transfers between testnets, which is the most common use case for XCM. See the prints below, when using mainnets it is possible to make this kind of transfer, but with testnets it is not possible. How could we test XCM transfers on testnets in this way? It is possible to enable this functionality?

Networks available:
image (35)

Doing XCM with Mainnets:
image (36)

Doing XCM with Testnets:

image (37)

image (38)

@0xslipk
Copy link
Contributor Author

0xslipk commented Aug 24, 2023

@rubenguc thank you for the answer. Let me explain in more detail what is happening. The problem is not showing the testnet list, is when you select one of the testnets on the list, there is only the option to make XCM transfer to the same testnet. There is no option to make XCM transfers between testnets, which is the most common use case for XCM. See the prints below, when using mainnets it is possible to make this kind of transfer, but with testnets it is not possible. How could we test XCM transfers on testnets in this way? It is possible to enable this functionality?

Networks available: image (35)

Doing XCM with Mainnets: image (36)

Doing XCM with Testnets:

image (37)

image (38)

Hi @dsm-w3f,

We added the functionality for testnet on version v0.3.7. We mainly tested in the relayer chain, but you are right, we should allow do the same on testnet.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 25, 2023

@0xslipk and @rubenguc thank you for the improvements and fixes. Now I was able to test the XCM transfer. See details in the evaluation document. The milestone is approved. I'll forward you invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 8eba8ee into w3f:master Aug 25, 2023
6 checks passed
@github-actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding. Common Good projects have a good chance of receiving Treasury Funding.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@RouvenP
Copy link

RouvenP commented Sep 1, 2023

hi @0xslipk we just transferred the payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants