Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Monitoring Service Milestone 1 #971

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Validator Monitoring Service Milestone 1 #971

merged 6 commits into from
Oct 17, 2023

Conversation

avtishin
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1791

@Ali-Usama
Copy link
Contributor

Hi @avtishin, I'm having this error with docker-compose -f docker-compose.yml -f polkadot.yml up

 => CANCELED [bot 4/6] RUN pip3 install -r requirements.txt                                                                                                        62.6s
 => [polkadot_events_exporter linter 1/4] FROM docker.io/golangci/golangci-lint:v1.53-alpine@sha256:b61d8503f0ad16499c023772301ec8c0f2559bf76c28d228c390446c5e647f  0.0s
 => [polkadot_events_exporter builder 1/6] FROM docker.io/library/golang:1.20-alpine@sha256:03278bc16e1a5b4fb6cdd3462108c060aa1e9c2353ce4d15d744b3c40168677d        0.0s
 => CACHED [polkadot_events_exporter stage-2 1/3] FROM docker.io/library/alpine:3.17@sha256:f71a5f071694a785e064f05fed657bf8277f1b2113a8ed70c90ad486d6ee54dc        0.0s
 => [polkadot_events_exporter internal] load build context                                                                                                          0.0s
 => => transferring context: 736B                                                                                                                                   0.0s
 => CACHED [polkadot_events_exporter builder 2/6] WORKDIR /build/                                                                                                   0.0s
 => CACHED [polkadot_events_exporter linter 2/4] WORKDIR /build/                                                                                                    0.0s
 => CACHED [polkadot_events_exporter linter 3/4] COPY . .                                                                                                           0.0s
 => ERROR [polkadot_events_exporter linter 4/4] RUN golangci-lint run                                                                                              58.9s
 => CACHED [polkadot_finality_exporter stage-1 1/8] FROM docker.io/library/python:3.11-slim-buster@sha256:c46b0ae5728c2247b99903098ade3176a58e274d9c7d2efeaaab3e06  0.0s
 => [polkadot_finality_exporter linter 1/4] FROM docker.io/alpine/flake8:latest@sha256:650d28dc43cba13893a0a4f79dcf30d27f87c1d8410d90663deb32fbaeccdbd1             0.0s
 => [polkadot_common_exporter internal] load build context                                                                                                          0.0s
 => => transferring context: 177B                                                                                                                                   0.0s
 => CANCELED [polkadot_common_exporter stage-1 2/8] RUN apt-get update && apt-get install -y gcc g++                                                               58.4s
 => [polkadot_finality_exporter internal] load build context                                                                                                        0.0s
 => => transferring context: 177B                                                                                                                                   0.0s
 => CANCELED [polkadot_finality_exporter stage-1 2/8] RUN apt-get update && apt-get install -y gcc g++                                                             58.4s
 => CACHED [polkadot_common_exporter linter 2/4] WORKDIR /apps/                                                                                                     0.0s
 => CACHED [polkadot_common_exporter linter 3/4] COPY . /apps/                                                                                                      0.0s
 => CACHED [polkadot_common_exporter linter 4/4] RUN flake8 --ignore="E501" *.py                                                                                    0.0s
------
 > [polkadot_events_exporter linter 4/4] RUN golangci-lint run:
#0 58.76 level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/sirupsen/logrus\""
#0 58.76 level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/sirupsen/logrus\"\n\n"
------
failed to solve: process "/bin/sh -c golangci-lint run" did not complete successfully: exit code: 3

Can you please look into it?
Thank you

@avtishin
Copy link
Contributor Author

Hey @Ali-Usama thanks for noting, I believe that RUN golangci-lint run --timeout=180s will help, we already added this to the corresponding Docker file (exporters/events/Dockerfile)

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 18, 2023

@avtishin thank you for the milestone delivery and @Ali-Usama for the external evaluation. Please see the evaluation document and provide the proper answers and fixes. Let me know when I can continue this evaluation.

@avtishin
Copy link
Contributor Author

@dsm-w3f thank you for such deep evaluation. We will prepare all requested changes)

@avtishin
Copy link
Contributor Author

avtishin commented Sep 1, 2023

@dsm-w3f hey, hope you are well. Please, take a look at the repo once again, we incorporated all requested changes. Now you should be able to run all exporters, use a tg bot that sends you a link to your dashboard, and track metrics. As well as links are fixed.
Moreover, I need to notice that /promalert is excessive in the current Milestone. This part relates to “Telegram bot adding alerting based on events” part will be made during the second Milestone. Full functionality of /promalert is expected in the 2nd Milestone. The option is added as a preparation for the 2nd Milestone (from the development perspective it was much easier to implement the option when we were working on a tg bot but full functionality for tg alerting will be released next). I hope I’m not being confusing)

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 4, 2023

@avtishin thank you for the improvements and fixes. This time the bot didn't starter because of a problem in one of the docker containers. Please see the evaluation document for details. Let me know when I can continue this evaluation.

@avtishin
Copy link
Contributor Author

avtishin commented Sep 5, 2023

@dsm-w3f Actually, it looks like a local problem. One of the packages did not download for some reason. Is your internet connection stable? I suggest cleaning everything saved from the previous run using make clean or docker-compose -f docker-compose.yml -f kusama.yml -f polkadot.yml down -v.
We have tested the latest version and we do not find this issue.
Please, let us know if the problem remains.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 6, 2023

@avtishin thank you for the answer. I tried again with another machine and internet connection and had the same problem. Are you sure that is not a cache problem on your side?

I ran docker system prune -a --volumes before building and running the containers with docker compose. Make sure to stop all containers before running this command.

I also noticed that the package that is producing the problem (aiogram) is not with the specific version set in the requirements.txt, also the code used looks like based on an outdated example of telegram webhook. Maybe by building all images you could reproduce the error or set the proper version in the requirements.txt to fix it.

Let me know when I can continue this evaluation.

@avtishin
Copy link
Contributor Author

@dsm-w3f hey, you are right. they released a new package version just after our last submission without backward compatibility. We added versions numbers in requirements.txt. You can continue. Thanks!

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 11, 2023

@ashlink11 thank you for the fix. I was able to run it again but now some commands are failing. Please see the evaluation document for details. Let me know when I can continue this evaluation.

@semuelle
Copy link
Member

pinging @avtishin

@avtishin
Copy link
Contributor Author

@Ali-Usama @semuelle Sorry, guys, we remember, need some more time to fix

@github-actions github-actions bot added the stale label Oct 14, 2023
@avtishin
Copy link
Contributor Author

@dsm-w3f please, take a look. I made a number of fixes. Once again, sorry for the delay

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 17, 2023

@avtishin thank you for the improvements and fixes. The milestone is approved. Please use the link below to submit the invoice. After that, the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 71bdf4a into w3f:master Oct 17, 2023
6 checks passed
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@avtishin
Copy link
Contributor Author

@dsm-w3f Thanks; the invoice is submitted. I am looking forward to completing the second milestone)

@avtishin
Copy link
Contributor Author

avtishin commented Nov 3, 2023

@dsm-w3f hey, we submitted an invoice more than two weeks ago. However, we have not received the payment yet.

@semuelle
Copy link
Member

semuelle commented Nov 6, 2023

Hey @avtishin. Sorry for the long wait. Your invoice will be processed this week. Please let me know if you haven't received anything by Friday EOB.

@RouvenP
Copy link

RouvenP commented Nov 10, 2023

hi @avtishin apologies for the delay. We transferred the funds today.

@avtishin
Copy link
Contributor Author

@semuelle @RouvenP thanks, all received!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants