MangoSale_Milestone_2

[Mangoboxlabs]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1400< please fill this in with the PR number of your application.

[keeganquigley]

Thanks for the delivery @Mangoboxlabs you can find my initial evaluation here. Note the failed test.

There is a lot of Solidity-style NatSpec comments in your code. As far as I'm aware, NatSpec and Doxygen formatting isn't compatible with Rust. Instead Rust uses rustdoc via cargo doc. Is there a reason you have included these? I've never seen them in ink! contracts before.

[Mangoboxlabs]

@keeganquigley Thank you for your answer. Regarding the code warning,We have made modifications based on your question. Please retrieve the latest code and try again.Regarding the style of annotations, due to our omission, we mistakenly used the solidity style because our project comes from solidity. Now we have corrected it.

[keeganquigley]

Thanks for the changes @Mangoboxlabs please see my evaluation for further issues and let me know if you are able to provide fixes. Thank you.

[Mangoboxlabs]

@keeganquigley Thank you very much for your reply. We have resolved the front-end issue. Please pull the latest code and try again. Regarding the issue of compilation failure, you need to install binaryen. You can install it through the following methods.

• npm install -g binaryen
• Debian/Ubuntu: apt-get install binaryen
• Homebrew: brew install binaryen
• Arch Linux: pacman -S binaryen
• Windows: binary releases at https://github.com/WebAssembly/binaryen/releases

Alternatively, by compiling and installing

cd /opt/   //can be any directory
sudo git clone https://github.com/WebAssembly/binaryen.git
cd ./binaryen
sudo cmake . && sudo make  
./bin/wasm-opt --version
cd /usr/local/bin
ln -s /opt/binaryen/bin/wasm-opt wasm-opt
wasm-opt --version 

As for what you said, our cargo contract version is too old because our project was developed a long time ago, and considering the cost, we have not yet upgraded to the new version.

[keeganquigley]

Thanks for the changes @Mangoboxlabs much appreciated. I have updated my eval accordingly. I'm able to sign the transaction with my test account, but there are now two additional UI tests that fail. I think this is happening because the inital createToken test doesn't complete due to a lack of funds in the test wallet. I understand how to send funds from Alice to the extension wallet on a local testnet and on the live testnet, but how can I send funds to the account in the Docker version since there is no node running? Thanks for your help.

[Mangoboxlabs]

@keeganquigley Thank you for your answer. We have already explained in the document how to obtain gas, which is local and online .
After connecting to the node, select the Account tab, then select any account and click Send to send it to your designated address.

At the same time, we have also optimized the testing content. Please pull the latest code for testing.

[keeganquigley]

Thanks @Mangoboxlabs I was able to get everything working now; I was reading the instructions wrong. I was confused because "Way 2" is listed twice for both methods and I wasn't sure if I still needed to connect to a node. I think the instructions could still be made more clear.

An even better way to test would be to package it using Docker Compose to spin up 3 containers simultaneously: a contracts-node with the correct params, the front-end, and the cypress e2e tests. Regardless, I was able to get it up and running and test all the contract functions manually and with e2e tests. Therefore I'm happy to pass this milestone, nice work!

[Mangoboxlabs]

Hi, @keeganquigley , any update on payment? Thanks~

[keeganquigley]

Hi @Mangoboxlabs thanks for inquiring. I am checking internally with the operations team and I will get back to you.

[keeganquigley]

Hi again @Mangoboxlabs I checked with the team and the invoice will be paid on Friday. Let us know if you don't receive it after the 15th. Thank you!

[Mangoboxlabs]

@keeganquigley Thank you very much for your help.