Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External evaluation of XCM domain milestone 1 #952

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

dastansam
Copy link
Contributor

Milestone delivery PR: #951
Link to the application pull request: w3f/Grants-Program#1733

@semuelle
Copy link
Member

semuelle commented Aug 1, 2023

Hey @dastansam. Thanks for your contributions! We noticed that you submitted three draft evaluations in the past day and a half. Going forward, we would prefer if everyone only did one evaluation at a time. We will leave the ones you already opened open, but might close some in the future if there are too many at a time, so as to give more people the chance to contribute.

Hope that doesn't deter you. Keep up the good work.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 3, 2023

@dastansam as you have only this external evaluation at this moment, let me know if you want to proceed and continue this evaluation.

@dastansam
Copy link
Contributor Author

dastansam commented Aug 3, 2023

@dastansam as you have only this external evaluation at this moment, let me know if you want to proceed and continue this evaluation.

hey @dsm-w3f,

I am completing the evaluation ASAP. thank you

@dastansam dastansam marked this pull request as ready for review August 3, 2023 20:01
@dastansam
Copy link
Contributor Author

dastansam commented Aug 3, 2023

Hey @dsm-w3f

I have updated the evaluation. For me, the report looks good and provided potential solutions seem feasible from the technical perspective

@dsm-w3f dsm-w3f self-assigned this Aug 4, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 4, 2023

@dastansam thank you for the external evaluation. It is approved. I'll forward your KSM payment. Great job!

@dsm-w3f dsm-w3f merged commit ee425f0 into w3f:master Aug 4, 2023
3 checks passed
@dastansam
Copy link
Contributor Author

dastansam commented Aug 7, 2023

Hey @dastansam. Thanks for your contributions! We noticed that you submitted three draft evaluations in the past day and a half. Going forward, we would prefer if everyone only did one evaluation at a time. We will leave the ones you already opened open, but might close some in the future if there are too many at a time, so as to give more people the chance to contribute.

Hope that doesn't deter you. Keep up the good work.

hey @semuelle @dsm-w3f @keeganquigley,

just wanted to confirm, one at a time here means one evaluation in review or one open draft pull request? For example, I have one not merged evaluation PR right now, does it mean that I can't submit new evaluations before it is accepted/merged? Or can I start new one?

thanks

@semuelle
Copy link
Member

semuelle commented Aug 7, 2023

Please wait until the other evaluations have been merged. We'll look into them as soon as possible.

Thank you for your contributions!

@dastansam dastansam deleted the xcm-domain-evaluation branch August 8, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants