External evaluation of security marketplace #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Whisker17
changed the title
semuelle
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Hi @Whisker17. Thanks for the evaluation. Couple of requests:
- The milestone table should contain a column titled "Accepted" to indicate whether each deliverable is accepted or not.
- The evaluation notes column should contain notes from you, not from the grantee.
- As described in the template, "ideally all links inside the above table should include the commit hash, which was used for testing the delivery." This is to avoid confusion later if any files are moved and to make sure the results are reproducible.
|
Hey @semuelle, sorry about my misoperation, I've fixed the table, hope it works. |
Whisker17
force-pushed
the
945-security-marketplace-m1
branch
from
662e806
to
1634fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress.
Milestone delivery PR: #945
Link to the application pull request: w3f/Grants-Program#1726