Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External evaluation of Contracts tool milestone 1 #933

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

Whisker17
Copy link
Contributor

All the milestone deliverables are provided and work as expected.

Application: https://github.com/w3f/Grants-Program/blob/master/applications/contracts-tool.md
Milestone delivery PR: #927

@dsm-w3f dsm-w3f self-assigned this Jul 24, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 25, 2023

@Whisker17 thank you for the external evaluation. I'll not merge it yet since we had two external evaluations for this milestone delivery. This is something new for us. We will discuss internally how to handle this case and circle back to you soon.

@Whisker17
Copy link
Contributor Author

Whisker17 commented Jul 26, 2023

Thanks for your reply. @dsm-w3f
I think this is a result of a lack of clarity in the external evaluation process, @Ali-Usama and I were both interested in a grant at the same time and had it externally evaluated, initially Ali submitted a PR but I realized that there was only general information about the grant (see this commit) so I submitted my PR after completing my evaluation and left a message for Ali hoping that it wouldn't be controversial. I think it's inevitable that this will happen as the number of grants grows and this is a good opportunity to clarify the external evaluation process.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 27, 2023

@Whisker17 we discussed internally and in this case we will accept both evaluations. However, our guidelines will be updated soon to include that external evaluators open a draft PR as soon as they start to work to avoid duplicate evaluations. I'll forward your KSM payment. Great job!

@dsm-w3f dsm-w3f merged commit 0cdcca7 into w3f:master Jul 27, 2023
3 checks passed
@Whisker17
Copy link
Contributor Author

@Whisker17 we discussed internally and in this case we will accept both evaluations. However, our guidelines will be updated soon to include that external evaluators open a draft PR as soon as they start to work to avoid duplicate evaluations. I'll forward your KSM payment. Great job!

Thanks for your reply! @dsm-w3f

I couldn't agree more with starting the external evaluation with a DRAFT PR first, looking forward to more details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants