Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milestone 2 supersig_fellowship #920

Merged
merged 1 commit into from
Jul 14, 2023
Merged

milestone 2 supersig_fellowship #920

merged 1 commit into from
Jul 14, 2023

Conversation

decentration
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1630 < please fill this in with the PR number of your application.

@dastansam
Copy link
Contributor

hey @decentration!

here is the evaluation of your milestone!

@decentration
Copy link
Contributor Author

@dastansam glad to see the eval went smoothly after that one fix 👍

@dsm-w3f dsm-w3f self-assigned this Jul 14, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 14, 2023

@decentration thank you for the milestone delivery and @dastansam thanks for the external evaluation. The evaluation looks good to me. I found only some problems with docker, which may not occur in all systems. Worthwhile to check but this don't prevent the acceptance of the milestone. The milestone is accepted. I'll forward the invoice internally and the payment should take place within two weeks. Great Job!

See the problems found with docker below:

docker run --rm -it --name supersig-ui -p 3000:3000  decentration/supersig-ui:latest
Unable to find image 'decentration/supersig-ui:latest' locally                                                                                                                               
latest: Pulling from decentration/supersig-ui                                                                                                                                                
5af00eab9784: Pull complete 
2965f8acff1c: Pull complete 
8bcab8bf4013: Pull complete 
cde13b50385f: Pull complete 
1855b0fd6ff7: Pull complete 
02730c2c29c3: Pull complete 
042a1e45f17f: Pull complete 
eb1410a85d91: Pull complete 
Digest: sha256:0e50482042eccfebdc476e110fe7b25381d0541b60af2c6686c7eeeac616320c                                                                                                              
Status: Downloaded newer image for decentration/supersig-ui:latest                                                                                                                           
WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested                                   
exec /usr/bin/yarn: exec format error 

Building locally the image also presented a error. I changed the Dockerfile the line 8 from RUN curl -SL https://deb.nodesource.com/setup_lts.x | bash - to RUN curl -fsSL https://deb.nodesource.com/setup_lts.x | bash - and solved the problem with npm. After this, I ran docker run --rm -it --name supersig-ui -p 3000:3000 decentration/supersig-ui:latest with the local image, and the application started.

Would be nice also to fix some cargo clippy warnings and check yarn lint since seem that the command is not working for the frontend project.

@dsm-w3f dsm-w3f merged commit 76a857d into w3f:master Jul 14, 2023
@github-actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding. Common Good projects have a good chance of receiving Treasury Funding.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@decentration
Copy link
Contributor Author

@dsm-w3f thanks Diogo, in the process of fixing linting (so we can deploy the build). Regarding the docker, i think its because i pushed the image from my mac m2. I also made the change you requested. Cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants