-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
milestone 2 supersig_fellowship #920
Conversation
hey @decentration! here is the evaluation of your milestone! |
@dastansam glad to see the eval went smoothly after that one fix 👍 |
@decentration thank you for the milestone delivery and @dastansam thanks for the external evaluation. The evaluation looks good to me. I found only some problems with docker, which may not occur in all systems. Worthwhile to check but this don't prevent the acceptance of the milestone. The milestone is accepted. I'll forward the invoice internally and the payment should take place within two weeks. Great Job! See the problems found with docker below:
Building locally the image also presented a error. I changed the Dockerfile the line 8 from Would be nice also to fix some |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
@dsm-w3f thanks Diogo, in the process of fixing linting (so we can deploy the build). Regarding the docker, i think its because i pushed the image from my mac m2. I also made the change you requested. Cheers 👍 |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1630 < please fill this in with the PR number of your application.