Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sandox_st1_ms1_delivery.md #919

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

TradeLinkEstonia
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the Statemint account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1694

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 14, 2023

@TradeLinkEstonia tank you for the milestone delivery and thanks @dastansam for the evaluation. I think the evaluation looks good. The application works well as presented in the demo video. However, seem that some syntax errors are not being handled. Please see the example below, the + operator is missing and the application does not show the error, which is handled by the browser console. Is it simple to fix this case?

image

Firefox:
image

Chrome:
image

@TradeLinkEstonia
Copy link
Contributor Author

Hello, @dsm-w3f , @dastansam
We have added executable permissions to build.sh and added dist to .gitignore
Also, we have reviewed and fixed the error handling mechanism, so now all syntax errors should be handled.
image_2023-07-17_13-19-30

@dastansam
Copy link
Contributor

from my side, it lgtm @dsm-w3f

@TradeLinkEstonia
Copy link
Contributor Author

Hello, team!
We'd like to proceed with the next Milestone. Is it everything ok here on this stage?

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 24, 2023

@TradeLinkEstonia thank you for the improvements and fixes. I tested again and now it is working. The milestone is approved. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 4c0db4c into w3f:master Jul 24, 2023
6 checks passed
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@TradeLinkEstonia
Copy link
Contributor Author

Hello, @dsm-w3f Diogo! We are in full swing for the delivery of the second milestone in a few weeks. Could you, please, help me to figure out the payment status for the delivered one?

@meldien
Copy link

meldien commented Aug 12, 2023

@TradeLinkEstonia payment will be executed in the next 3 days.
Stay you updated.
Best wishes,
Melanie

@meldien
Copy link

meldien commented Aug 16, 2023

@TradeLinkEstonia transfer done

@TradeLinkEstonia
Copy link
Contributor Author

@TradeLinkEstonia transfer done

Received! Thank you! Looking forward for the next delivery!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants