Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solang milestone 2 #915

Merged
merged 1 commit into from
Jul 14, 2023
Merged

add solang milestone 2 #915

merged 1 commit into from
Jul 14, 2023

Conversation

salaheldinsoliman
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program@eba3474

Signed-off-by: salaheldinsoliman <[email protected]>
@dsm-w3f dsm-w3f self-assigned this Jul 12, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 13, 2023

@salaheldinsoliman thank you for the milestone delivery and thanks @stojanov-igor for the external evaluation. Please consider the comments included in the external evaluation and also this one. Let me know when I can continue this evaluation.

@salaheldinsoliman
Copy link
Contributor Author

@dsm-w3f @stojanov-igor
Thanks for your feedback!
I see the two main points concerning are as follows:
1- cargo test fails:
You could fix this by cloning the submodules, please run git submodule update --init --recursive and then retry cargo test and it should work.

2- you can't see a difference with verbose flag.
You're correct. I handled this issue in this PR: hyperledger-solang/solang#1441.

3- For the test coverage, the maintainers do not have cargo tarpaulin in the CI tests. Anyways, I will suggest it to them but I think this is a different issue.

@dsm-w3f you can continue with the evaluation I think

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 14, 2023

@salaheldinsoliman thank you for the answers and fixes. The remainder problems were fix. The milestone is approved. I'll forward your invoice internally and the payment should take place within two weeks. Great Job!

@dsm-w3f dsm-w3f merged commit 67d921e into w3f:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants