External evaluation of Sirato milestone 1 #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @dastansam thanks for the thorough evaluation! The only thing I noticed was a minor license file fix. Everything else looks great. Before accepting, could you update the evaluation status to "accepted"? After that I'll merge it. Thanks! |
|
I changed the status to |
|
Thanks @dastansam I will forward your KSM address for payment. |
6 tasks
|
hi @dastansam we just transferred the KSM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, it's well-documented and majority of the instructions are clear. Code is well written and structured. There are only few minor issues that could be easily addressed.
Milestone Delivery PR: #892
Application PR: w3f/Grants-Program#1608