Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TogetherCrew: Community Health Check #864

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

katerinabc
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#1482

@katerinabc
Copy link
Contributor Author

The Twitter vibez dashboard will contain 3 sections: basic engagement, friendship and community type. In the friendship section we make a distinction between supporters and ambassadors. The community type shows users if they have a healthy Twitter community or an audience.

Link to milestone: https://github.com/RnDAO/tc-Documentation/blob/master/Twitter-vibes/Twitter_Community_Vibes.md

@randombishop randombishop self-assigned this May 16, 2023
@randombishop
Copy link
Contributor

Thanks for the delivery @katerinabc !
Will review in next few days and get back to you with feedback...

@katerinabc
Copy link
Contributor Author

Thanks for the delivery @katerinabc ! Will review in next few days and get back to you with feedback...

I was wondering if you have feedback for us. Thanks.

@randombishop
Copy link
Contributor

Sorry didn't have time to start yet but I will eval before end of this week

@randombishop
Copy link
Contributor

Hi @katerinabc !

I reviewed the article and I found it very interesting. The approach is clearly defined and an excellent start to kick-off the dashboard development.

But I have a concern that it's too generic and doesn't deliver anything Polkadot specific yet.

From the milestone specification:

We will build a directed network, where nodes are always Twitter users. From a network assembly perspective, we will not differentiate between accounts representing people and those representing communities or organizations. The edges between an user profiles are either a reply, quote, mention, retweets, or likes. Thus, a tie from user A to user B exists if (1) user A replies to user B, user A quotes user B, user A mentions user B, user A retweets user B, or user A likes user B's tweet. At this moment, we will created weighted edges, not making a conceptual difference between the interaction type (reply, quote, mention, retweets and likes)

My expectation was to find actual Polkadot/Kusama network data at this stage; but instead there are just the definitions of how the graph will look like.

I will discuss with the rest of the team on Monday to check if we can accept this delivery as-is.

In the meantime, would you consider making progress in the actual network building and add some Polkadot/Kusama specific information to the article? For example, how many nodes are in the graph? how they were selected?

Thank you!

@katerinabc
Copy link
Contributor Author

My expectation was to find actual Polkadot/Kusama network data at this stage; but instead there are just the definitions of how the graph will look like.

There might have been a misunderstanding as I expected to deliver a technical document about how we are building it.

Would you consider making progress in the actual network building and add some Polkadot/Kusama specific information to the article? For example, how many nodes are in the graph? how they were selected?

This should be possible. I'll be able to let you know if this is possible in 48 hours.

@katerinabc
Copy link
Contributor Author

@randombishop We will be able to update the milestone 1 document at the end of next week. I'll let you know when it's done

@randombishop
Copy link
Contributor

Thank you very much @katerinabc ! Appreciate your extra effort

@semuelle
Copy link
Member

pinging @katerinabc

@katerinabc
Copy link
Contributor Author

Not sure I understand

@katerinabc
Copy link
Contributor Author

@randombishop We're delayed on getting the data for Polkadot + Kusama as we were all working on getting the community health check app for discord released.

@randombishop randombishop removed their assignment Jun 15, 2023
@randombishop
Copy link
Contributor

Hey @katerinabc, thanks for the update!
@keeganquigley will actually pick up this evaluation once you update it, thanks to you too Keegan!

@keeganquigley
Copy link
Contributor

Hi @katerinabc an additional note:

I noticed that your license file contains a short header that is meant to be applied to specific source files being used in your work. Per the Apache 2.0 policy, each repository should contain one full copy of the license, in the license file. Can you please update this to include the full text? Here is an example. Thanks!

@keeganquigley
Copy link
Contributor

pinging @katerinabc for an update :)

@keeganquigley
Copy link
Contributor

Hi @katerinabc are you still working on this delivery? If you can update/fix the license file I will check with the team again to see if we can accept the delivery as is.

I'll try reaching out to you on Twitter as well. Thanks!

@katerinabc
Copy link
Contributor Author

@keeganquigley I can update the header in the license file. @randombishop asked for some changes which we have not yet been able to deliver due to changes in the Twitter API. I was assuming that the practical work will only be done for milestone 2. Re-reading the messages, I'm assuming these are the requested changes. Please confirm.

Request 1:
Include basic information about the Polkadot and Kusama network. For example, how many nodes are in the graph? how they were selected? (#864 (comment); My expectation was to find actual Polkadot/Kusama network data at this stage; but instead there are just the definitions of how the graph will look like.)

Request 2:
Add the license file to each header in the repo and include the full text (see the example.

@keeganquigley
Copy link
Contributor

keeganquigley commented Jul 7, 2023

Thanks for the update @katerinabc much appreciated.

Request 1: Yes I can confirm that those were the changes I was referring to. Pardon me as I took over this delivery for my colleague. After re-reading your application I agree that no technical work was required as part of the first milestone. If you can fix the license file, I will consult with the committee internally to see if we can accept it as is.

Request 2: No, I am just asking to replace the header in your license file with the full Apache 2.0 license text. Currently it is just the header. I hope this helps.

@katerinabc
Copy link
Contributor Author

I've updated the license file to include the full license text and not just the header information

@keeganquigley
Copy link
Contributor

Thanks for the changes @katerinabc, much appreciated. The first milestone only contains the article, and since the delivery technically meets the requirements, I'm willing to accept it. But I agree that the research is rather generic. For the second milestone, it would be nice to see to see some data relating specifically to the Polkadot ecosystem. You can find the evaluation here. I will forward your invoice for processing.

@keeganquigley keeganquigley merged commit 0771053 into w3f:master Jul 25, 2023
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants