Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRUCIAL DAO - Milestone 1 #557

Merged
merged 1 commit into from
Dec 2, 2022
Merged

QRUCIAL DAO - Milestone 1 #557

merged 1 commit into from
Dec 2, 2022

Conversation

sixTheDave
Copy link
Contributor

@sixTheDave sixTheDave commented Aug 31, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#989

@sixTheDave
Copy link
Contributor Author

Greetings,

@Noc2 we'd like to ping for an update. The development goes on, we are already working on features of M2.

Any feedback at this point is very welcome!

@Noc2
Copy link
Collaborator

Noc2 commented Sep 9, 2022

That’s great to hear. Thanks for the delivery and sorry for the delay. Part of our team is currently ooo. An external evaluator will take a look at your delivery in the coming days.

@sixTheDave
Copy link
Contributor Author

sixTheDave commented Sep 12, 2022

That’s great to hear. Thanks for the delivery and sorry for the delay. Part of our team is currently ooo. An external evaluator will take a look at your delivery in the coming days.

@Noc2 No worries, we are patiently waiting for the evaluation. Please note that we started a new branch Milestone2 where we continue working on the project.

@dsm-w3f dsm-w3f self-assigned this Sep 15, 2022
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 15, 2022

@smilingSix thank you for the milestone submission and my apologies for the late response. Please see the evaluation document and provide proper answers and fixes. After that, let me know to continue with the evaluation.

@sixTheDave
Copy link
Contributor Author

@smilingSix thank you for the milestone submission and my apologies for the late response. Please see the evaluation document and provide proper answers and fixes. After that, let me know to continue with the evaluation.

No worries and thank you for starting the process. We review the document and provide the answers/fixes soon.

@sixTheDave
Copy link
Contributor Author

Hello @dsm-w3f ,

Here are some updates. We will still make some changes to fit all evaluation feedback evaluation points if those below are not enough, but please note that we are working on a very low budget here (20k) on widespread changes requested.

Improvements so far:

0c. - More testing and exploratory documents are added.

0d. - We have improved the docker image and added more documentation on how to run/use it. Installation of "tmux" and "keccak256-cli" are included in the guide as well.

Warnings are fixed: clippy and compile time.

Exo_pallet methods were there from the template, these are removed. Other improvements are added.

Audit_pallet methods are implemented and errors are solved.

Exosysd improvements are planned for M2 as it is a phase for code cleanup/hardening.

Comments are improved in the code for rustdoc (exo_pallet and exosys to be added later). We also created a related wiki page for that.

Substrate has been updated fully to the latest runtime - also to fix some errors.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 7, 2022

@smilingSix thank you for the improvements. I still have some problems with docker and now the tests are broken. I also need a complete example of running the process using the extrinsic and methods available. The evaluation document was updated with details. Regarding the low budget, these requests are really necessary to check your milestone deliverables and I think they will not take much time/effort to be done. No problem to plan improvements to M2, however, I need to check if the deliverables of M1 are working as declared in the grant proposal.

@sixTheDave
Copy link
Contributor Author

@smilingSix thank you for the improvements. I still have some problems with docker and now the tests are broken. I also need a complete example of running the process using the extrinsic and methods available. The evaluation document was updated with details. Regarding the low budget, these requests are really necessary to check your milestone deliverables and I think they will not take much time/effort to be done. No problem to plan improvements to M2, however, I need to check if the deliverables of M1 are working as declared in the grant proposal.

Sure thing, thank you for the fast response. We check the evaluation updates and move forward. I'll drop the next message when we are ready.

@sixTheDave
Copy link
Contributor Author

sixTheDave commented Oct 25, 2022

@dsm-w3f
The documentation has been updated and genesis blockchain config is added, so now it is possible to test system with default accounts (eg. Alice, Dave, etc). Does this solution work for you to move on?

The docker config is also updated and wiki is extended with more information (eg. how to expose port if needed).

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 27, 2022

@sixTheDave thank you for the improvements and fixes. Now the tests are passing but I still having problems with docker. The tutorial is covering a few features from what we have in this delivery. I updated the evaluation document with details. Please take a look and let me know when I could continue with the evaluation.

@sixTheDave
Copy link
Contributor Author

@sixTheDave thank you for the improvements and fixes. Now the tests are passing but I still having problems with docker. The tutorial is covering a few features from what we have in this delivery. I updated the evaluation document with details. Please take a look and let me know when I could continue with the evaluation.

Thank you, the problem with docker was that "git checkout milestone1" was not used before the docker build code. I have added this line to the tutorial.

A more detailed tutorial for the listed functions is on the way.

@sixTheDave
Copy link
Contributor Author

@Noc2 @dsm-w3f We have updated the documentation with more tutorials.

To speed up the process we'd appriciate if you join in our public dev Matrix room: https://matrix.to/#/#qdao_dev_pub:matrix.org

Sending messages here take a long time and we would be very happy to support the evaluation process with immediate answers.

Looking forward to the next step!

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Dec 2, 2022

@sixTheDave thank you for the explanations. The milestone was approved. There are some improvements that need to be handled in the next delivery, see details in the evaluation document. I'll forward internally your invoice and it should be payed within two weeks (could happen before). Good Job!

@dsm-w3f dsm-w3f merged commit 7363764 into w3f:master Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

@fededubbi
Copy link

Hi @sixTheDave,

I noticed on your invoice there is no payment address, could you please include it?
Do you want to be paid in USD or crypto?

Many thanks,
Federica

@sixTheDave
Copy link
Contributor Author

sixTheDave commented Dec 2, 2022

Hi @sixTheDave,

I noticed on your invoice there is no payment address, could you please include it? Do you want to be paid in USD or crypto?

Many thanks, Federica

Hi @fededubbi ,

I have updated the invoice, please pay in USD as this is easier to account for everyone now. In the next turn we might go with cryptocurrency.

Thank you,
six

@sixTheDave
Copy link
Contributor Author

@sixTheDave thank you for the explanations. The milestone was approved. There are some improvements that need to be handled in the next delivery, see details in the evaluation document. I'll forward internally your invoice and it should be payed within two weeks (could happen before). Good Job!

Thank you @dsm-w3f , it was good to go though M1 evaluation with you. We get the improvements/hardening/frontend done in M2.

@fededubbi
Copy link

Hi @sixTheDave, i noticed on the invoice there are 2 different accounts.
Which one should we use?

Many thanks,
Federica

@sixTheDave
Copy link
Contributor Author

Hi @sixTheDave, i noticed on the invoice there are 2 different accounts. Which one should we use?

Many thanks, Federica

Hi @fededubbi ,

Please use the USD account: https://wise.com/pay#piq3oJkPjsX90gLJIiLXJDP-Sg0

Thank you,
six

@fededubbi
Copy link

Hi @sixTheDave,

According to your contract you should be paid in BTC.
Could you please include the address on the invoice and resend it?

Let me know if this still works for you or if you prefer another cryptocurrency.

Many thanks,
Federica

@sixTheDave
Copy link
Contributor Author

Hi @sixTheDave,

According to your contract you should be paid in BTC. Could you please include the address on the invoice and resend it?

Let me know if this still works for you or if you prefer another cryptocurrency.

Many thanks, Federica

Hi @fededubbi

I updated and sent the invoice. This is the newly generated, correct BTC address: bc1qwr7awq55z2udjvxj0ar7qfeasf70fasee8fxf2

The old address is not valid anymore. Thank you.
six

@fededubbi
Copy link

Hi,

We check with our team and the BTC address on the invoice is not the same on the contract.
Could you please double check and replace it?

Many thanks,
Federica Dubbini

@sixTheDave
Copy link
Contributor Author

Hi,

We check with our team and the BTC address on the invoice is not the same on the contract. Could you please double check and replace it?

Many thanks, Federica Dubbini

Hi,

As I wrote above, the old address is not valid anymore, it has been replaced for security reasons. Please use the BTC address on the invoice. Please also match against the address for verification: bc1qwr7awq55z2udjvxj0ar7qfeasf70fasee8fxf2

Waiting for the transaction. Thank you,
six

@Noc2
Copy link
Collaborator

Noc2 commented Dec 13, 2022

@sixTheDave, in this case, could you update the original application via a PR and integrate the new address: https://github.com/w3f/Grants-Program/blob/master/applications/QRUCIAL_DAO.md This way, we follow the normal process. Thanks a lot

@sixTheDave
Copy link
Contributor Author

sixTheDave commented Dec 13, 2022

@sixTheDave, in this case, could you update the original application via a PR and integrate the new address: https://github.com/w3f/Grants-Program/blob/master/applications/QRUCIAL_DAO.md This way, we follow the normal process. Thanks a lot

@Noc2 Sure thing. I just sent the PR. Thank you!

Link to PR: w3f/Grants-Program#1359

@keeganquigley
Copy link
Contributor

Thanks @sixTheDave I just approved the amendment, and it shouldn't take long to get the last two approvals in order to transfer the payment.

@sixTheDave
Copy link
Contributor Author

Thanks @sixTheDave I just approved the amendment, and it shouldn't take long to get the last two approvals in order to transfer the payment.

Thank you for quick response, we are waiting for others.

@sixTheDave
Copy link
Contributor Author

Hi,

We check with our team and the BTC address on the invoice is not the same on the contract. Could you please double check and replace it?

Many thanks, Federica Dubbini

Hello,

The PR just went through, please proceed with the payment.

Best,
six

@sixTheDave
Copy link
Contributor Author

Hello @fededubbi ,

Can you please update us on the process? We are waiting for receiving the BTC.

@RouvenP
Copy link

RouvenP commented Dec 21, 2022

hi @sixTheDave apologies for the delay - we transferred the payment yesterday.

@sixTheDave
Copy link
Contributor Author

hi @sixTheDave apologies for the delay - we transferred the payment yesterday.

Thank you, we have received it. We are starting Milestone 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants