Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subxt python 2 evaluation #1214

Merged
merged 3 commits into from
Oct 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions evaluations/subxt-py_2_PieWol.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# Evaluation

- **Status:** accepted
- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/subxt-python.md
- **Milestone:** 2

**Deliverables**

| Number | Deliverable | Accepted | Link | Notes
| -----: |---------------------------|---------------------------|--------------------------------------------------------------------------------|---------------------------|
| **0a.** | License | <ul><li>[x] </li></ul> | [Apache 2.0](https://github.com/philoniare/subxtpy/blob/main/LICENSE.md) |
| **0b.** | Documentation | <ul><li>[x] </li></ul> | [Readme](https://github.com/philoniare/subxtpy/blob/main/README.md) | ok, what about ``patchelf``?
| **0c.** | Testing and Testing Guide | <ul><li>[x] </li></ul> | [Tests folder](https://github.com/philoniare/subxtpy/tree/main/tests) , [Testing Guide](https://github.com/philoniare/subxtpy/blob/main/README.md) | all passing
| 0e. | Article | <ul><li>[x] </li></ul> | [Article](https://www.philoniare.com/blog/real-time-subxtpy) | nice
| 1. | Subscription API | <ul><li>[x] </li></ul> | [Source Code](https://github.com/philoniare/subxtpy/blob/442dfafa6164d3a01da7fdb58fc018930a936a00/src/lib.rs#L597) |
| 2. | Streaming Support | <ul><li>[x] </li></ul> | [Source Code](https://github.com/philoniare/subxtpy/blob/442dfafa6164d3a01da7fdb58fc018930a936a00/src/lib.rs#L597) |
| 3. | Documentation Website | <ul><li>[x] </li></ul> | [github.io/subxtpy](https://philoniare.github.io/subxtpy/) | nice update
| 4. | Example Scripts | <ul><li>[x] </li></ul> | [Sample Python Scripts](https://github.com/philoniare/subxtpy/tree/main/tests) | ok
| 5. | Integration Guides | <ul><li>[x] </li></ul> | [Flask example](https://github.com/philoniare/subxtpy-flask-example) |
| 6. | Published pypi package | <ul><li>[x] </li></ul> | [pypi](https://pypi.org/project/subxtpy/) | nice

# General Notes
Thanks for the latest changes to the documentation. Everything looks good.

## Build
builds

````
(.venv) ubuntu@ip-172-31-18-251:~/subxtpy$ maturin develop
⚠️ Warning: You specified maturin ==1.5.1 in pyproject.toml under `build-system.requires`, but the current maturin version is 1.7.4
📦 Including license file "/home/ubuntu/subxtpy/LICENSE.md"
🔗 Found pyo3 bindings
🐍 Found CPython 3.12 at /home/ubuntu/subxtpy/.venv/bin/python
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s
📦 Built wheel for CPython 3.12 to /tmp/.tmpgibyAN/subxtpy-0.2.0-cp312-cp312-linux_x86_64.whl
✏️ Setting installed package as editable
🛠 Installed subxtpy-0.2.0
````


## Test
all passing.
```
========================================================================== test session starts ==========================================================================
platform linux -- Python 3.12.3, pytest-8.3.2, pluggy-1.5.0
rootdir: /home/ubuntu/subxtpy
configfile: pyproject.toml
plugins: asyncio-0.24.0
asyncio: mode=Mode.STRICT, default_loop_scope=None
collected 8 items

tests/test_constants_dynamic.py . [ 12%]
tests/test_events.py . [ 25%]
tests/test_runtime_api_call.py . [ 37%]
tests/test_storage_fetch_dynamic.py .. [ 62%]
tests/test_storage_iterating_dynamic.py . [ 75%]
tests/test_subscription.py . [ 87%]
tests/test_tx_basic.py . [100%]

=========================================================================== 8 passed in 0.27s ===========================================================================
(.venv) ubuntu@ip-172-31-18-251:~/subxtpy$
```