Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnix 2 evaluation #1202

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Dotnix 2 evaluation #1202

merged 4 commits into from
Aug 8, 2024

Conversation

PieWol
Copy link
Member

@PieWol PieWol commented Jul 30, 2024

No description provided.

@PieWol PieWol mentioned this pull request Jul 30, 2024
5 tasks
| 1. | Audit Trail | <ul><li>[ ] </li></ul> | [trail](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/pkgs/list-dependencies.nix) | |
| **0a.** | License | <ul><li>[x] </li></ul> | [LICENSE](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/LICENSE) | MIT |
| **0b.** | Documentation | <ul><li>[x] </li></ul> | [README](https://github.com/sporyon/dotnix-core/blob/9a0cc3705e10da23fb2743b1a2f76fd8f2c4c3c4/README.md) | — |
| **0c.** | Testing and Testing Guide | <ul><li>[ ] </li></ul> | [/checks](https://github.com/sporyon/dotnix-core/tree/470096931e56374ebc3fcc0af821dd774ef44d10/checks) | Testing guide looks fine but doesn't work atm. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide details in what way the test does not work. Running nix flake check --print-build-logs should complete without an error (exit code 0) which indicates a successful test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing guide didn't work for the docker setup. The regular tests were finishing without error thus passing.

| **0a.** | License | <ul><li>[x] </li></ul> | [LICENSE](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/LICENSE) | MIT |
| **0b.** | Documentation | <ul><li>[x] </li></ul> | [README](https://github.com/sporyon/dotnix-core/blob/9a0cc3705e10da23fb2743b1a2f76fd8f2c4c3c4/README.md) | — |
| **0c.** | Testing and Testing Guide | <ul><li>[ ] </li></ul> | [/checks](https://github.com/sporyon/dotnix-core/tree/470096931e56374ebc3fcc0af821dd774ef44d10/checks) | Testing guide looks fine but doesn't work atm. |
| **0d.** | Docker | <ul><li>[ ] </li></ul> | [docker.nix](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/docker.nix) | following the instructions doesn't work |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide details which instructions you used, building it yourself or downloading it. What issues did you run into.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building it myself. I didn't download the tarball manually. I think I mentioned this on your original delivery PR.

somehow the given command is not recognized in the docker instance. Did I do something wrong setting up the docker instance?

```[root@dfc0bf67828a:~]# list-dependencies --runtime PATH
-bash: list-dependencies: command not found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list-dependencies package was missing in the docker image it has been added in sporyon/dotnix-core@65e9520


```Jul 30 23:10:27 dfc0bf67828a systemd[1]: Started Polkadot Validator.
Jul 30 23:10:27 dfc0bf67828a polkadot[528]: Error:
Jul 30 23:10:27 dfc0bf67828a polkadot[528]: 0: Starting an authorithy without network key in /run/credentials/polkadot-validator.service/node_key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide the exact commands you have entered after starting the docker image and the full journal? Entering just polkadot key generate-node-key | polkadot-validator --set-node-key should start the validator. This functionality has been implemented as part of the previous milestone and has not been touched since.

We could reproduce the issue by first generating the key with polkadot key generate-node-key | polkadot-validator --set-node-key which successfully starts the validator, and subsequently resetting the key to the empty string by running polkadot-validator --set-node-key and pressing enter, which will restart the validator into the broken state.

At the moment set node key will not check if the provided key is valid. This is something which needs improvement in the future.

@PieWol PieWol merged commit 5087dcf into w3f:master Aug 8, 2024
3 checks passed
Copy link

github-actions bot commented Aug 8, 2024

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants