Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Solang Playground milestone 3 #1199

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

salaheldinsoliman
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1894

@ditavia-br
Copy link
Contributor

Hi, we'll do this evaluation.

@ditavia-br
Copy link
Contributor

@salaheldinsoliman thanks for the milestone delivery. Please take a look at the evaluation document in this PR and provide proper answers and fixes. The application worked well, we just have a doubt about the scope of the milestone delivery. Let me know when I can continue this evaluation.

@salaheldinsoliman
Copy link
Contributor Author

@ditavia-br Hello,
I addressed your questions in a comment in the PR. please let me know if the comment answers your questions

@ditavia-br
Copy link
Contributor

@salaheldinsoliman thanks for the answer. The milestone is accepted from our side. Great job!

@semuelle
Copy link
Member

Hey @salaheldinsoliman, I am doing a cursory review of the evaluation. I tried compiling the example contract using the deployed version you link in the repo README, but I'm getting ERR_CONNECTION_REFUSED in the console. Might be related to the certificate warning I'm getting, but this is on both Firefox and Chrome. Am I missing something?

@semuelle semuelle self-assigned this Aug 16, 2024
@salaheldinsoliman
Copy link
Contributor Author

@semuelle Hello, can you please try edge instead? and make sure the connection is http is instead of https ?
This is temporary, as we have initiated conversations with Hyperledger labs to provide a suitable domain name.
Please let me know if you still have problems

@keeganquigley
Copy link
Contributor

Hi @salaheldinsoliman thanks for your help, I was able to get it to run on both the deployed (unsecured) version and at http://localhost:9000/

playground

Unit tests are all passing but with a few warnings. Consider fixing these for the next milestone. Other than that I was able to reproduce everything, and since @ditavia-br has accepted your delivery, I'm happy to pass this milestone. Thanks for the nice work and looking forward to seeing UI improvements on the next one.

@keeganquigley keeganquigley merged commit 169c49e into w3f:master Aug 26, 2024
6 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants