Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperfridge milestone 4 delivery #1185

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

dastansam
Copy link
Contributor

@dastansam dastansam commented Jun 3, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2096

cc @wstrametz

@dastansam dastansam marked this pull request as ready for review June 3, 2024 03:35
@github-actions github-actions bot added the stale label Jun 17, 2024
@dastansam
Copy link
Contributor Author

hey there! would really appreciate if someone could take a look at this. thanks!
cc @keeganquigley @semuelle @PieWol

@semuelle semuelle removed the stale label Jun 17, 2024
@semuelle
Copy link
Member

Hi @dastansam. Sorry for the delay. Someone will look into it asap.

@PieWol PieWol self-assigned this Jun 17, 2024
@PieWol
Copy link
Member

PieWol commented Jun 18, 2024

Thank you for the delivery @dastansam.
I'm evaluating it and will get back to you shortly.

@PieWol
Copy link
Member

PieWol commented Jun 21, 2024

Hey @dastansam ,
could you please point me to instructions on how to run the e2e tests? Thanks!

@dastansam
Copy link
Contributor Author

Hey @dastansam , could you please point me to instructions on how to run the e2e tests? Thanks!

cargo test runs both unit and xcm-simulator e2e tests

@PieWol
Copy link
Member

PieWol commented Jun 24, 2024

Hey @dastansam ,
thanks for the awesome milestone delivery. It's accepted. 🎉
Here is the eval document.

@PieWol PieWol merged commit 1d1d56e into w3f:master Jun 24, 2024
6 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@dastansam dastansam deleted the hyperfridge-ms4 branch June 27, 2024 08:08
@RouvenP
Copy link

RouvenP commented Jul 9, 2024

hi @dastansam we sent the payment yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants