Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solang playground milestone 2 #1184

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

salaheldinsoliman
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1894

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jun 5, 2024

Hi, we'll evaluate this milestone.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jun 6, 2024

@salaheldinsoliman thanks for the milestone delivery. We did a first round of evaluation. Please take a look at the document in this PR and provide proper answers and fixes. After that, let me know to continue this evaluation.

Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman
Copy link
Contributor Author

salaheldinsoliman commented Jun 13, 2024

@dsm-w3f Hi,
We have addressed your comments, and accordingly updated the .md file. You can now proceed with the evaluation
@tareknaser

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jun 17, 2024

@salaheldinsoliman thank you for the improvements and fixes. We checked again and we still having problems to run the docker version of the application. Please see the evaluation PR for details. Please let me know when we can continue this evaluation.

@tareknaser
Copy link

Hey @dsm-w3f

Sorry about the trouble with the docker image! Solang released a new version 7 days ago, and we needed to update solang-playground as well. I pushed a commit with the fix and updated solang-playground images on Docker Hub. I also included more verbose instructions on how to run the docker image.

Give it another try - this should resolve the issue you were seeing. Let us know if you run into any other issues.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jun 19, 2024

@tareknaser and @salaheldinsoliman thank you for the improvements and fixes. We tested again and the docker is working. This milestone is approved from my side. Great work!

@github-actions github-actions bot added the stale label Jul 4, 2024
@semuelle
Copy link
Member

semuelle commented Jul 5, 2024

Sorry, @salaheldinsoliman, this milestone somehow slipped through the cracks. It's now approved.

@semuelle semuelle merged commit dce4e5d into w3f:master Jul 5, 2024
3 checks passed
Copy link

github-actions bot commented Jul 5, 2024

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants