Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecentralML - Milestone 1 Delivery #1079

Merged
merged 3 commits into from
Dec 19, 2023
Merged

DecentralML - Milestone 1 Delivery #1079

merged 3 commits into from
Dec 19, 2023

Conversation

AshleyTuring
Copy link
Contributor

@AshleyTuring AshleyTuring commented Dec 8, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1079

Copy link
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livetreetech could you add the url to the source of the documentation as well (in addition to the deployed gitbook)?

deliveries/decentralml_milestone_1.md Outdated Show resolved Hide resolved
fix bracket typo - thank @takasher

Co-authored-by: S E R A Y A <[email protected]>
@AshleyTuring
Copy link
Contributor Author

@livetreetech could you add the url to the source of the documentation as well (in addition to the deployed gitbook)?

Not sure what you mean - does clicking this give you edit rights? https://app.gitbook.com/o/JGQQdHzEzlbR15Ezbn9M/s/Wt5ixztAjbKCHHNS4hEX/task-overview if not please let me know how I get the edit link. Thank you.

@takahser
Copy link
Contributor

@livetreetech nope, it doesn't:
image

I'm pretty sure you have a github repo that serves as a source for these docs. That's the URL that should be added to the delivery document.

@AshleyTuring
Copy link
Contributor Author

@takahser You can try this one https://app.gitbook.com/invite/JGQQdHzEzlbR15Ezbn9M/S6iumDpmx2X6wgd3gNb2
In any case it wont show you code documentation, you can run the cargo -h (see readme) to build all the code docs

@semuelle semuelle self-assigned this Dec 12, 2023
@takahser
Copy link
Contributor

@livetreetech it didn't work, but I don't think it's necessary anyway.
image

In any case it wont show you code documentation, you can run the cargo -h (see readme) to build all the code docs

Ah true, according to the embedded docs section in your README it seems like the docs are contained in your repo already, so that should be fine then.

@semuelle
Copy link
Member

Hey @livetreetech. Just a quick update: I haven't managed to go through all deliverables, but everything looks great so far. I hope to be able to wrap up the evaluation tomorrow.

@AshleyTuring
Copy link
Contributor Author

@semuelle thanks very much for the update

@semuelle
Copy link
Member

Hey @livetreetech. I am following the testing guide using Docker. I got to this step, but then I get the following error running the command. Can you advise?

root@e9cbafd7a843:~/decentralml# python3 -m substrate-client-decentralml.create_task_ipfs
/usr/bin/python3: Error while finding module specification for 'substrate-client-decentralml.create_task_ipfs' (ModuleNotFoundError: No module named 'substrate-client-decentralml')

Unfortunately, the local install doesn't work either:

> poetry install
Traceback (most recent call last):
  File "/usr/bin/poetry", line 5, in <module>
    from poetry.console import main
  File "/usr/lib/python3/dist-packages/poetry/console/__init__.py", line 1, in <module>
    from .application import Application
  File "/usr/lib/python3/dist-packages/poetry/console/application.py", line 3, in <module>
    from cleo import Application as BaseApplication
ImportError: cannot import name 'Application' from 'cleo' (/home/dml/.local/lib/python3.10/site-packages/cleo/__init__.py)

@semuelle
Copy link
Member

pinging @livetreetech

@AshleyTuring
Copy link
Contributor Author

Hey @livetreetech. I am following the testing guide using Docker. I got to this step, but then I get the following error running the command. Can you advise?

root@e9cbafd7a843:~/decentralml# python3 -m substrate-client-decentralml.create_task_ipfs

/usr/bin/python3: Error while finding module specification for 'substrate-client-decentralml.create_task_ipfs' (ModuleNotFoundError: No module named 'substrate-client-decentralml')

Unfortunately, the local install doesn't work either:

> poetry install

Traceback (most recent call last):

  File "/usr/bin/poetry", line 5, in <module>

    from poetry.console import main

  File "/usr/lib/python3/dist-packages/poetry/console/__init__.py", line 1, in <module>

    from .application import Application

  File "/usr/lib/python3/dist-packages/poetry/console/application.py", line 3, in <module>

    from cleo import Application as BaseApplication

ImportError: cannot import name 'Application' from 'cleo' (/home/dml/.local/lib/python3.10/site-packages/cleo/__init__.py)

Sorry totally missed those, I'm on the rust side Mathias is on the python. I'll ask him tomorrow and come back to you sorry for the delay.

@AshleyTuring
Copy link
Contributor Author

pinging @livetreetech

@semuelle

Dr. Mathias Ciliberto — Today at 08:49
I have updated the documentation. The command is:
python3 -m decentralml.create_task_ipfs

@semuelle
Copy link
Member

Thanks for the update, @livetreetech. However, python can't seem to find a create_task_ipfs method. I'm not very familiar with Python, so if there is some step before/in between that I'm supposed to be doing, like an install or changing directories, please let me know.

I am able to run python3 -m decentralml.examples. However, after selecting option 1, I don't see anything happening, even after waiting for several minutes. Is there debug output somewhere I could inspect?

node_decentralml    | 2023-12-19 10:17:09 💤 Idle (0 peers), best: #0 (0xb0b5…90c4), finalized #0 (0xb0b5…90c4), ⬇ 0 ⬆ 0    
node_decentralml    | 2023-12-19 10:17:14 💤 Idle (0 peers), best: #0 (0xb0b5…90c4), finalized #0 (0xb0b5…90c4), ⬇ 0 ⬆ 0    
client_decentralml  | root@e9cbafd7a843:/decentralml/substrate-client-decentralml# python3 -m decentralml.examples
Functionality to tests:
client_decentralml  | 1 - Create tasks
client_decentralml  | 2 - Assign tasks
client_decentralml  | 3 - Send task results
client_decentralml  | 4 - Exit
client_decentralml  | Select your example: 1
node_decentralml    | 2023-12-19 10:17:16 Accepting new connection 1/100
node_decentralml    | 2023-12-19 10:17:19 💤 Idle (0 peers), best: #0 (0xb0b5…90c4), finalized #0 (0xb0b5…90c4), ⬇ 0 ⬆ 0    
node_decentralml    | 2023-12-19 10:17:24 💤 Idle (0 peers), best: #0 (0xb0b5…90c4), finalized #0 (0xb0b5…90c4), ⬇ 0 ⬆ 0    
node_decentralml    | 2023-12-19 10:17:29 💤 Idle (0 peers), best: #0 (0xb0b5…90c4), finalized #0 (0xb0b5…90c4), ⬇ 0 ⬆ 0    

Locally, I still get the ImportError: cannot import name 'Application' from 'cleo' (/home/dml/.local/lib/python3.10/site-packages/cleo/__init__.py) error, so it'd be great if you could review either one and let me know how to proceed. Feel free to reach out via Matrix, might be faster.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @livetreetech. Thanks for the help, your milestone is hereby accepted. You can find my evaluation notes here.

@semuelle semuelle merged commit 82ea134 into w3f:master Dec 19, 2023
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@meldien
Copy link

meldien commented Dec 22, 2023

@livetreetech
Thank you for providing the invoice.

Could you please add your full address and adding our billing information as well.

Web 3.0 Technologies Foundation
Baarerstrasse 14
6300 Zug

Many thank for adding the missing information and providing the invoice.

Best,
Melanie

@AshleyTuring
Copy link
Contributor Author

AshleyTuring commented Dec 22, 2023

@livetreetech Thank you for providing the invoice.

Could you please add your full address and adding our billing information as well.

Web 3.0 Technologies Foundation Baarerstrasse 14 6300 Zug

Many thank for adding the missing information and providing the invoice.

Best, Melanie
@meldien
Thanks Melanie, I have emailed and resubmitted the form. Lmk if there is anything further required.

@semuelle and the rest of the grants team
Thank you for the support. Have a nice Christmas.

@semuelle
Copy link
Member

Hey @livetreetech. Sorry, another thing: the entity and address on the invoice doesn't match the ones in the application. Could you update either one to match the other?

@AshleyTuring
Copy link
Contributor Author

AshleyTuring commented Dec 23, 2023

Apologies @semuelle I missed that, I have updated the original application, however, the commit does not seem to be reflecting on the PR 1818 . @takahser mentioned it might be better to create another PR so, I've done so here PR 2164. For ease I have also attached it decentral_ml.md to this comment as well if you wish to simply replace 1818 on your side. Thanks for the help and have a good festive break.

@semuelle
Copy link
Member

the commit does not seem to be reflecting on the PR 1818

Hey @livetreetech. I just left a comment on the open PR. Already merged PRs don't update, so creating a new PR is the right move. Yours contains two files, though. Other than that, it looks good.

@AshleyTuring
Copy link
Contributor Author

Hi @semuelle
I added the additional file as previous commits did not reflect. Apologies, Git can be frustrating, anyhow, I believe I have now deleted the additional file which can be seen here Have a great start to the new year. If you could process this as soon as possible it would be appreciated.

@semuelle
Copy link
Member

semuelle commented Jan 2, 2024

Hey @livetreetech, one more thing: the invoice contains only bank details as payment information, but according to the grant agreement it should be paid in USDC. Could you add the payment address to the invoice or amend the grant agreement to reflect fiat payment?

@AshleyTuring
Copy link
Contributor Author

Hi @semuelle, thanks for the message, the invoice seems to have the address, I have emailed it to you: s***@web3.foundation let me know, if there is something else required. Best wishes, A-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants