-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ink! analyzer (phase 2) - milestone 5 #1041
Conversation
Thanks for the delivery @davidsemakula someone will look at it within the next few days, as we currently have a backlog. |
@takahser Added more notes and updated the recommended tag for testing to a newer release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidsemakula thanks for your patience, it looks mostly good already. I had troubles with spinning up the docker infrastructure though. Feel free to have a look at my evaluation for more details.
@takahser thanks for the thorough review and feedback. I've pushed a fix for the docker issue to the master branch. |
@takahser LMK if I need to clarify anything for the docker fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidsemakula it's all fine, I've retested it, and it worked well! You can find the final evaluation here.
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
Thanks for the review @takahser 🎉 |
@RouvenP just checking in since it's about 2 weeks now since the approval 🙂 |
hi @davidsemakula the payment will be settled today - I will let you know as soon as done! |
hi @davidsemakula the transfer is done |
Hi @RouvenP received, thanks! |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1904 < please fill this in with the PR number of your application.