Skip to content

Commit

Permalink
Update centrifuge-gsrpc-v2_2_niklabh.md
Browse files Browse the repository at this point in the history
  • Loading branch information
@semuelle
semuelle authored Jun 28, 2023
1 parent 4555168 commit c50e083
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions evaluations/centrifuge-gsrpc-v2_2_niklabh.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
|--------|----------------------------------|-------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------|
| 1. | License | <ul><li>[x] </li> </ul> | [License](https://github.com/centrifuge/go-substrate-rpc-client/blob/event-parsing-v2/LICENSE) | Apache License v2 |
| 2. | Documentation | <ul><li>[ ] </li> </ul> | [Documentation](https://github.com/centrifuge/go-substrate-rpc-client/blob/event-parsing-v2/registry/REGISTRY.md) | Documentation Needs to be improved |
| 3. | PR with changes | <ul><li>[ ] </li> </ul> | [centrifuge/go-substrate-rpc-client#338](https://github.com/centrifuge/go-substrate-rpc-client/pull/338) | PR looks good |
| 4a. | Registry Unit Tests | <ul><li>[ ] </li> </ul> | [UnitTest](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/registry_test.go) | Unit Test coverage is good |
| 4b. | Registry (Events) Live Tests | <ul><li>[ ] </li> </ul> | [Events Live Tests](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/retriever/event_retriever_live_test.go) | Error in running docker tests, submitted a [PR](https://github.com/centrifuge/go-substrate-rpc-client/pull/353) to fix |
| 3. | PR with changes | <ul><li>[x] </li> </ul> | [centrifuge/go-substrate-rpc-client#338](https://github.com/centrifuge/go-substrate-rpc-client/pull/338) | PR looks good |
| 4a. | Registry Unit Tests | <ul><li>[x] </li> </ul> | [UnitTest](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/registry_test.go) | Unit Test coverage is good |
| 4b. | Registry (Events) Live Tests | <ul><li>[x] </li> </ul> | [Events Live Tests](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/retriever/event_retriever_live_test.go) | Error in running docker tests, submitted a [PR](https://github.com/centrifuge/go-substrate-rpc-client/pull/353) to fix |
| 4c. | Registry (Extrinsics) Live Tests | <ul><li>[ ] </li> </ul> | [Extrinsics Live Tests](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/retriever/extrinsic_retriever_live_test.go) | Live test against public endpoints. Tests are running for too long. No need to check for 1000 events. 50 are fine |
| 4d. | Test execution | <ul><li>[x] </li> </ul> | [Test execution](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/Makefile#L49-L53) | Makefile has a [error](https://github.com/centrifuge/go-substrate-rpc-client/issues/352) |
| 5. | Dockerfile | <ul><li>[x] </li> </ul> | [Dockerfile](https://github.com/centrifuge/go-substrate-rpc-client/blob/b9da36ebf177cbb3ee41c2ef2b9a1fb08e5f8522/Dockerfile_milestone2) | Dockerfile is provided |
Expand Down Expand Up @@ -571,4 +571,4 @@ go: downloading github.com/go-stack/stack v1.8.1
--- PASS: TestLive_EventRetriever_GetEvents (1.59s)
PASS
ok github.com/centrifuge/go-substrate-rpc-client/v4/registry/retriever 1.599s
```
```

0 comments on commit c50e083

Please sign in to comment.