Add evaluation v2

w3f · Jul 21, 2023 · 663508a · 663508a
1 parent 348ae4f
commit 663508a
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/evaluations/swift_api_2_dastansam.md b/evaluations/swift_api_2_dastansam.md
@@ -1,6 +1,6 @@
 # Evaluation
 
-- **Status:** In Progress
+- **Status:** Accepted
 - **Application Document:** [swift_api.md](https://github.com/w3f/General-Grants-Program/blob/master/grants/speculative/swift_api.md)
 - **Milestone:** 2
 - **Kusama Identity:** [Fd1SvYZnE3dZ3mEaq5QG1HEWhzNrDyMPJ41C4fQqiMirtTP](https://sub.id/Fd1SvYZnE3dZ3mEaq5QG1HEWhzNrDyMPJ41C4fQqiMirtTP)
@@ -12,7 +12,7 @@
 | ------------- | ------------- | ------------- |------------- |
 | 0a. | License |[Apache 2.0](https://github.com/tesseract-one/Substrate.swift/blob/main/LICENSE)| Correct license | 
 | 0b. | Documentation | [README](https://github.com/tesseract-one/Substrate.swift/blob/main/README.md) | Extensive documentation |
-| 0c. | Testing Guide |[gdoc](https://docs.google.com/document/d/1LrINndmDI_1QnrpCwcV62EFKvIxylCHwH7oY5BJJXtY)| Helpful testing guide, some integration tests are failing. Logs for tests below |
+| 0c. | Testing Guide |[gdoc](https://docs.google.com/document/d/1LrINndmDI_1QnrpCwcV62EFKvIxylCHwH7oY5BJJXtY)| Helpful testing guide, all tests are passing. Logs for tests below |
 | 1. | Swift wrapper for C sr25519 library | [Sr25519.swift](https://github.com/tesseract-one/Sr25519.swift) | Wrappers for Sr25519 and Ed25519 library are provided with tests. |
 | 2. | In-App Keychain | [Keychain](https://github.com/tesseract-one/Substrate.swift/tree/main/Sources/Keychain) | In-app keychain support is delivered, with extensive unit tests. |
 | 3. |  Dynamic Type Registry | [Runtime](https://github.com/tesseract-one/Substrate.swift/tree/main/Sources/Substrate/Runtime) | Dynamic type registry is delivered, with unit tests |
@@ -23,6 +23,8 @@
 | 8. | Hashers | [Hashers.swift](https://github.com/tesseract-one/Substrate.swift/blob/main/Sources/Substrate/Types/Hashers.swift) | All hashers (Blake2, TwoX, Identity) and AnyHasher(dynamic) are provided and work as expected |
 | 9. | JsonRPC Client | [JsonRPC](https://github.com/tesseract-one/JsonRPC.swift) | Json RPC client with WebSocket and HTTP connections is delivered |
 
+# Evaluation V1
+
 ## General Notes
 
 In general, everything is documented and a nice testing guide is provided. Test application is also provided and it demonstrates how to integrate the library to a Swift application. Test app compiles and runs smoothly.
@@ -312,4 +314,8 @@ End of Transfer Batch Transaction
 Program ended with exit code: 0
 ```
 
-</details>
+</details>
+
+# Evaluation v2
+
+All integration tests are now passing when running with the following command `TEST_MNEMONIC="<mnemonic_from_test_app>" swift test`.