-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject ICE servers with an authority component or / #2998
base: main
Are you sure you want to change the base?
Conversation
Complete integration of URL parser from #2853 see also #2997 (comment) This aligns with the constraints set in the respective RFC (and thus with the current WebRTC Rec)
The writing of tests has shown that there are a number of URIs that are "legal" according to the URL parser algorithm, but do not conform to the ABNF for:
We should make a decision on whether these URIs should be rejected or not; authority components are just one example of such nonconformance. |
Validating the test stun URLs against the RFC7064 ABNF, it shows the following RFC-invalid values:
The last 4 are addressed by this pull request. |
Among the list above:
|
Conversely, the following are detected as invalid by the URL spec but not by the RFC ABNF:
|
I have just verified (on the set of URLs in the test case) that we can use the URL parser to normalize the "TWUS-valid but not RFC-valid" URLs into RFC-valid URLs. We would need to complete the algorithm so that it doesn't just validate the urls, but replace them with the normalized values out of the parsing, by adding a final step to replace |
Complete integration of URL parser from #2853
see also #2997 (comment) This aligns with the constraints set in the respective RFC (and thus with the current WebRTC Rec)
Preview | Diff