Merge pull request #2992 from w3c/fix-amendments-23

Fix description of amendments 23, 31, 47
w3c · Aug 30, 2024 · d27ecc1 · d27ecc1
2 parents cf143f6 + 1bd3982
commit d27ecc1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 28 deletions.
diff --git a/amendments.json b/amendments.json
@@ -270,11 +270,12 @@
       "id": 23
     }
   ],
-  "rtcpeerconnectioniceevent-attributes": [
+  "rtcpeerconnectioniceevent-url-desc": [
     {
       "description": "Add deprecation notice to RTCPeerConnectionIceEvent.url",
       "pr": 2773,
       "testUpdates": "not-testable",
+      "difftype": "append",
       "type": "correction",
       "status": "candidate",
       "id": 23
@@ -678,7 +679,7 @@
       "id": 30
     }
   ],
-  "setcodecparameters-algorithm": [
+  "codecmatch-algorithm": [
     {
       "description": "Fix ambiguities in the setCodecPreferences() algorithm",
       "pr": 2847,
@@ -688,7 +689,6 @@
       "testUpdates": "already-tested",
       "type": "correction",
       "status": "candidate",
-      "difftype": "append",
       "id": 31
     },
     {
@@ -702,7 +702,6 @@
       ],
       "type": "correction",
       "status": "candidate",
-      "difftype": "append",
       "id": 47
     }
   ],
@@ -848,21 +847,6 @@
       "id": 42
     }
   ],
-  "setcodecpreferences-receive": [
-    {
-      "description": "setCodecPreferences only takes into account receive codecs",
-      "pr": 2926,
-      "type": "correction",
-      "status": "candidate",
-      "tests": [
-	"webrtc/RTCRtpTransceiver-setCodecPreferences.html"
-      ],
-      "testUpdates": [
-        "web-platform-tests/wpt#44318"
-      ],
-      "id": 42
-    }
-  ],
   "rtcrtpreceiver-receivecodecs": [
     {
       "description": "Redefine SendCodecs and ReceiveCodecs",

diff --git a/base-rec.html b/base-rec.html
@@ -7016,7 +7016,7 @@ <h5 id="constructors-2">
               </dl>
             </section>
             <section>
-              <h5 id="rtcpeerconnectioniceevent-attributes">
+              <h5>
                 Attributes
               <a class="self-link" aria-label="§" href="#rtcpeerconnectioniceevent-attributes"></a></h5>
               <dl data-link-for="RTCPeerConnectionIceEvent" data-dfn-for="RTCPeerConnectionIceEvent" class="attributes">
@@ -7041,7 +7041,7 @@ <h5 id="rtcpeerconnectioniceevent-attributes">
                   <dfn data-idl="attribute" data-export="" data-dfn-type="attribute" id="dom-rtcpeerconnectioniceevent-url" data-title="url" data-dfn-for="RTCPeerConnectionIceEvent" data-type="DOMString" data-lt="url" data-local-lt="RTCPeerConnectionIceEvent.url"><code>url</code></dfn> of type <span class="idlAttrType">DOMString</span>, readonly, nullable
                 </dt>
                 <dd>
-                  <p>
+                  <p id="rtcpeerconnectioniceevent-url-desc">
                     The <a data-link-type="idl" href="#dom-rtcpeerconnectioniceevent-url" class="internalDFN" id="ref-for-dom-rtcpeerconnectioniceevent-url-3"><code><code>url</code></code></a> attribute is the STUN or TURN URL that
                     identifies the STUN or TURN server used to gather this
                     candidate. If the candidate was not gathered from a STUN or
@@ -11102,8 +11102,7 @@ <h4 id="methods-8">
                   When <a data-link-type="idl" data-lt="setCodecPreferences()" href="#dom-rtcrtptransceiver-setcodecpreferences" class="internalDFN" id="ref-for-dom-rtcrtptransceiver-setcodecpreferences-6"><code><code>setCodecPreferences</code></code></a><code>()</code> in invoked, the <a href="#dfn-user-agent" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-user-agent-11">user
                   agent</a> <em class="rfc2119">MUST</em> run the following steps:
                 </p>
-		</div>
-                <ol id="setcodecparameters-algorithm">
+                <ol>
                   <li class="no-test-needed">
                     <p>
                       Let <var>transceiver</var> be the <a data-link-type="idl" href="#dom-rtcrtptransceiver" class="internalDFN" id="ref-for-dom-rtcrtptransceiver-66"><code><code>RTCRtpTransceiver</code></code></a>
@@ -11174,7 +11173,8 @@ <h4 id="methods-8">
                     </p>
                   </li>
                 </ol>
-		<div id="setcodecparameters-algorithm"></div>
+		</div>
+		<div id="codecmatch-algorithm"><!-- added as anchor to new algo in revised spec --></div>
                 <div class="note" role="note" id="issue-container-generatedID-47"><div role="heading" class="note-title marker" id="h-note-47" aria-level="5"><span>Note</span></div><p class="">
                   If set, the offerer's codec preferences will decide the order
                   of the codecs in the offer. If the answerer does not have any

diff --git a/webrtc.html b/webrtc.html
@@ -6767,7 +6767,7 @@ <h2>
                 Attributes
               </h2>
               <dl data-link-for="RTCPeerConnectionIceEvent" data-dfn-for=
-              "RTCPeerConnectionIceEvent" id="rtcpeerconnectioniceevent-attributes" class="attributes">
+              "RTCPeerConnectionIceEvent">
                 <dt data-tests="RTCPeerConnectionIceEvent-constructor.html">
                   <dfn data-idl="">candidate</dfn> of type <span class=
                   "idlAttrType">{{RTCIceCandidate}}</span>, readonly, nullable
@@ -6790,15 +6790,15 @@ <h2>
                   <dfn data-idl="">url</dfn> of type <span class=
                   "idlAttrType">DOMString</span>, readonly, nullable
                 </dt>
-                <dd>
+                <dd id="rtcpeerconnectioniceevent-url-desc">
                   <p>
                     The {{url}} attribute is the STUN or TURN URL that
                     identifies the STUN or TURN server used to gather this
                     candidate. If the candidate was not gathered from a STUN or
                     TURN server, this parameter will be set to
                     <code>null</code>.
                   </p>
-                  <p class="note add-to-rtcpeerconnectioniceevent-attributes">
+                  <p class="note add-to-rtcpeerconnectioniceevent-url-desc">
                     This attribute is deprecated; it exists for legacy compatibility reasons only.
                     Prefer the candidate {{RTCIceCandidate/url}}.
                   </p>
@@ -11423,7 +11423,7 @@ <h2>
                   </li>
                 </ol>
 		</div>
-                <div  id="setcodecparameters-algorithm">
+                <div id="codecmatch-algorithm">
                 <p>  The <dfn class="export">codec dictionary match</dfn> algorithm
                   given two {{RTCRtpCodec}} dictionaries
                   <var>first</var> and <var>second</var> is as follows: