Skip to content

Commit

Permalink
Use more granular diff targets for amendments 19, 20, 21, 24, 32, 49
Browse files Browse the repository at this point in the history 
Allows to deal with different maturity levels
  • Loading branch information
@dontcallmedom
dontcallmedom committed Oct 3, 2024
1 parent e1f8c77 commit 63bf02f
Show file tree
Hide file tree
Showing 3 changed files with 133 additions and 28 deletions.
137 changes: 121 additions & 16 deletions amendments.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,87 @@
"difftype": "append"
}
],
"setparameters-algo": [
"setparameters-codec-validation-1": [
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"id": 49,
"pr": 2985,
"difftype": "append",
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"setparameters-codec-validation-2": [
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"id": 49,
"pr": 2985,
"difftype": "append",
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"setparameters-codec-validation-3": [
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"id": 49,
"pr": 2985,
"difftype": "append",
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"setparameters-codec-validation-4": [
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"difftype": "append",
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"setparameters-codec-validation-5": [
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"difftype": "append",
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"setparameters-srbd-mv-validation-1": [
{
"description": "Remove RTCRtpEncodingParameters.scaleResolutionDownBy for audio",
"pr": [2772, 2799],
Expand All @@ -490,8 +570,25 @@
],
"type": "correction",
"status": "proposed",
"difftype": "append",
"id": 20
},
{
"description": "Add RTCRtpEncodingParameters.maxFramerate",
"pr": 2785,
"tests": [
"webrtc/RTCRtpParameters-maxFramerate.html"
],
"testUpdates": [
"web-platform-tests/wpt#43173"
],
"type": "addition",
"status": "proposed",
"difftype": "append",
"id": 19
}
],
"setparameters-srbd-mv-validation-2": [
{
"description": "Default RTCRtpEncodingParameters.scaleResolutionDownBy to 1 for video",
"pr": 2772,
Expand All @@ -503,8 +600,26 @@
],
"type": "correction",
"status": "proposed",
"difftype": "append",
"id": 21
},
}
],
"setparameters-srbd-mv-validation-3": [
{
"description": "Remove RTCRtpEncodingParameters.scaleResolutionDownBy for audio",
"pr": [2772, 2799],
"tests": [
"webrtc/RTCRtpParameters-encodings.html"
],
"testUpdates": [
"web-platform-tests/wpt#37477"
],
"type": "correction",
"status": "proposed",
"id": 20
}
],
"setparameters-srbd-mv-validation-4": [
{
"description": "Add RTCRtpEncodingParameters.maxFramerate",
"pr": 2785,
Expand All @@ -516,28 +631,18 @@
],
"type": "addition",
"status": "proposed",
"difftype": "append",
"id": 19
},
}
],
"setparameters-stopped": [
{
"description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
"pr": 2829,
"testUpdates": "already-tested",
"type": "correction",
"status": "candidate",
"id": 32
},
{
"description": "Add codec to RTCRtpEncodingParameters",
"type": "addition",
"status": "candidate",
"id": 49,
"pr": 2985,
"tests": [
"webrtc/RTCRtpParameters-codec.html"
],
"testUpdates": [
"web-platform-tests/wpt#47663"
]
}
],
"init-srbd": [
Expand Down
4 changes: 2 additions & 2 deletions base-rec.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9050,7 +9050,7 @@ <h4 id="methods-6">
<var>sender</var> (i.e. <var>sender</var> is
<var>transceiver</var>.<a href="#dfn-sender" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-sender-19">[[Sender]]</a>).
</li>
<li data-tests="RTCRtpSender-setParameters.html,RTCRtpTransceiver.https.html" class="has-tests">
<li data-tests="RTCRtpSender-setParameters.html,RTCRtpTransceiver.https.html" class="has-tests" id="setparameters-stopped">
If <var>transceiver</var>.<a href="#dfn-stopped-0" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-stopped-0-8">[[Stopped]]</a> is
<code>true</code>, return a promise <a data-link-type="dfn" href="#dfn-reject" class="internalDFN" id="ref-for-dfn-reject-35">rejected</a> with a
newly <a data-link-type="dfn" data-type="dfn" href="https://heycam.github.io/webidl/#dfn-create-exception">created</a> <a data-link-type="idl" data-type="exception" href="https://heycam.github.io/webidl/#invalidstateerror"><code>InvalidStateError</code></a>.
Expand Down Expand Up @@ -9094,7 +9094,7 @@ <h4 id="methods-6">
</li>
</ol>
</li>
<li data-tests="RTCRtpParameters-encodings.html" class="has-tests">
<li data-tests="RTCRtpParameters-encodings.html" class="has-tests" id="setparameters-srbd-mv-validation-3">
<p>
Verify that each encoding in <var>encodings</var> has
a <a data-link-type="idl" href="#dom-rtcrtpencodingparameters-scaleresolutiondownby" class="internalDFN" id="ref-for-dom-rtcrtpencodingparameters-scaleresolutiondownby-9"><code><code>scaleResolutionDownBy</code></code></a>
Expand Down
20 changes: 10 additions & 10 deletions webrtc.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9027,7 +9027,7 @@ <h2>
<var>transceiver</var>.{{RTCRtpTransceiver/[[Sender]]}}).
</li>
<li data-tests=
"RTCRtpSender-setParameters.html,RTCRtpTransceiver.https.html">
"RTCRtpSender-setParameters.html,RTCRtpTransceiver.https.html" id="setparameters-stopped">
If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
<code>true</code>, return a promise [= rejected =] with a
newly [= exception/created =] {{InvalidStateError}}.
Expand All @@ -9048,14 +9048,14 @@ <h2>
<li class="no-test-needed">Let <var>codecs</var> be <var>
parameters</var>.{{RTCRtpParameters/codecs}}.
</li>
<li>
<li id="setparameters-codec-validation-1">
<p>Let <var>choosableCodecs</var> be <var>codecs</var>.</p>
</li>
<li>
<li id="setparameters-codec-validation-2">
<p>If <var>choosableCodecs</var> is an empty list, set <var>choosableCodecs</var>
to transceiver.{{RTCRtpTransceiver/[[PreferredCodecs]]}}.</p>
</li>
<li>
<li id="setparameters-codec-validation-3">
<p>If <var>choosableCodecs</var> is still an empty list, set <var>choosableCodecs</var>
to the [=RTCRtpSender/list of implemented send codecs=] for transceiver's kind.</p>
</li>
Expand Down Expand Up @@ -9084,13 +9084,13 @@ <h2>
Note that this also applies to
<var>transactionId</var>.
</li>
<li>
<li id="setparameters-codec-validation-4">
Any <var>encoding</var> in encodings [=map/exists|contains=] a codec
[= codec dictionary match | not found =] in <var>choosableCodecs</var>.
</li>
</ul>
</li>
<li data-tests="RTCRtpParameters-encodings.html">
<li data-tests="RTCRtpParameters-encodings.html" id="setparameters-srbd-mv-validation-1">
<p>
If [=RTCRtpTransceiver/transceiver kind=] is `"audio"`, remove the
{{RTCRtpEncodingParameters/scaleResolutionDownBy}} and
Expand All @@ -9099,7 +9099,7 @@ <h2>
[=map/contain=] any of them.
</p>
</li>
<li data-tests="RTCRtpParameters-encodings.html">
<li data-tests="RTCRtpParameters-encodings.html" id="setparameters-srbd-mv-validation-2">
<p>
If [=RTCRtpTransceiver/transceiver kind=] is `"video"`, then for
each encoding in <var>encodings</var> that doesn't
Expand All @@ -9110,7 +9110,7 @@ <h2>
member with the value `1.0`.
</p>
</li>
<li data-tests="RTCRtpParameters-encodings.html">
<li data-tests="RTCRtpParameters-encodings.html" id="setparameters-srbd-mv-validation-3">
<p>
If [=RTCRtpTransceiver/transceiver kind=] is `"video"`,
and any encoding in <var>encodings</var>
Expand All @@ -9121,7 +9121,7 @@ <h2>
exception/created =] {{RangeError}}.
</p>
</li>
<li data-tests="RTCRtpParameters-encodings.html">
<li data-tests="RTCRtpParameters-encodings.html" id="setparameters-srbd-mv-validation-4">
<p>
Verify that each encoding in <var>encodings</var> has
a {{RTCRtpEncodingParameters/maxFramerate}}
Expand All @@ -9132,7 +9132,7 @@ <h2>
exception/created =] {{RangeError}}.
</p>
</li>
<li>
<li id="setparameters-codec-validation-5">
<p>If the user agent does not support setting the codec for any encoding or mixing
different codec values on the different encodings, return a promise [= rejected =]
with a newly [= exception/created =] {{OperationError}}.
Expand Down

0 comments on commit 63bf02f

Please sign in to comment.