Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a candidate pair match algorithm. #193

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

sam-vi
Copy link
Contributor

@sam-vi sam-vi commented Dec 20, 2023

Fixes: #187.

This PR depends on the candidate match algorithm described in #192.

The candidate pair match algorithm will be used in validation steps for RTCIceTransport methods (#188).


Preview | Diff

Fixes: w3c#187.

This PR depends on the candidate match algorithm described in w3c#192.

The candidate pair match algorithm will be used in validation steps for RTCIceTransport methods (w3c#188).
sam-vi added a commit to sam-vi/webrtc-extensions that referenced this pull request Jan 10, 2024
This depends on several other PRs to be merged first:
- w3c#170: Addition of removeCandidatePair method
- w3c#192: Definition of candidate match algo
  - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object
    equality
- w3c#193: Definition of candidate pair match algo
- w3c#194: Addition of CandidatePairs internal slot
sam-vi added a commit to sam-vi/webrtc-extensions that referenced this pull request Jan 10, 2024
This depends on several other PRs to be merged first:
- w3c#170: Addition of removeCandidatePair method
- w3c#192: Definition of candidate match algo
  - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object
    equality
- w3c#193: Definition of candidate pair match algo
- w3c#194: Addition of CandidatePairs internal slot
sam-vi added a commit to sam-vi/webrtc-extensions that referenced this pull request Jan 12, 2024
This depends on several other PRs to be merged first:
- w3c#170: Addition of removeCandidatePair method
- w3c#192: Definition of candidate match algo
  - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object
    equality
- w3c#193: Definition of candidate pair match algo
- w3c#194: Addition of CandidatePairs internal slot
sam-vi added a commit to sam-vi/webrtc-extensions that referenced this pull request Jan 12, 2024
This depends on several other PRs to be merged first:
- w3c#170: Addition of removeCandidatePair method
- w3c#192: Definition of candidate match algo
  - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object
    equality
- w3c#193: Definition of candidate pair match algo
- w3c#194: Addition of CandidatePairs internal slot
@henbos henbos merged commit 4c29534 into w3c:main Jan 12, 2024
2 checks passed
@sam-vi sam-vi deleted the samvi-187-pair-match branch January 12, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe a match algorithm for two RTCIceCandidatePairs
3 participants