Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-spec links and references #174

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Jan 14, 2020

Minor editorial updates to fix a few broken links and correct references:


Preview | Diff

Minor editorial updates to fix a few broken links and correct references:
- Drop custom definitions that are no longer needed
- Replace "triggered by user activation" with new user activation model
(see whatwg/html#5129)
- Use back ticks for values instead of var shorthand
- Drop link to feature name in Feature Policy (term no longer exists)
Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating spec.
See my only comment below.

index.bs Outdated
@@ -501,7 +491,7 @@ This specification defines a <a>policy-controlled feature</a> that controls
whether the <a>request Picture-in-Picture algorithm</a> may return a
{{SecurityError}} and whether {{pictureInPictureEnabled}} is `true` or `false`.

The <a>feature name</a> for this feature is `"picture-in-picture"`.
The feature name for this feature is `"picture-in-picture"`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "feature name" doesn't exist anymore, shall we update spec text that says "If the document is not allowed to use the policy-controlled feature named "picture-in-picture", throw a SecurityError and abort these steps." as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, to avoid the dubious repetition "the feature name for this feature is", I just pushed an update to merge the sentence here with the previous paragraph .

Even though the term "feature name" is no longer defined, it still seems reasonable to talk about the name of a feature, so I didn't try to update the algorithm step. If you prefer, we could perhaps simply drop "named" in both cases to end up with 'policy-controlled feature "picture-in-picture"'.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f4b4902 looks good to me.

Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@beaufortfrancois beaufortfrancois merged commit 9a28dfa into w3c:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants