-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change figure & figcaption accName computation #359
Closed
Closed
Commits on Jan 20, 2022
-
Change figure & figcaption accName computation
resolves #325 This PR revises the mappings for `figure` and `figcaption` to remove the "labelled by" relations, changing them to "details for". The accessible name computation for `figure` removes `figcaption`, a note is added to further reference this change. TODO: - [ ] need to check on updates to UIA mapping, if any. - [ ] do we want `figcaption` to map to `caption`? - [ ] regardless of above, [`caption`](https://w3c.github.io/aria/#caption) will need to be updated in regards to its referencing `figure` and `figcaption` relationships - [ ] [`aria-details`](https://w3c.github.io/aria/#aria-details) definition should be updated to reference this change
Configuration menu - View commit details
-
Copy full SHA for 941668e - Browse repository at this point
Copy the full SHA 941668eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f0436 - Browse repository at this point
Copy the full SHA c1f0436View commit details
Commits on Feb 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 472d40e - Browse repository at this point
Copy the full SHA 472d40eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a0f361 - Browse repository at this point
Copy the full SHA 0a0f361View commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8d36f54 - Browse repository at this point
Copy the full SHA 8d36f54View commit details
Commits on Apr 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8e3e598 - Browse repository at this point
Copy the full SHA 8e3e598View commit details -
add in AX details for figure's relationship to figcaption
cc @cookiecrook to make sure i got this right. thank you
Configuration menu - View commit details
-
Copy full SHA for 8841502 - Browse repository at this point
Copy the full SHA 8841502View commit details -
Configuration menu - View commit details
-
Copy full SHA for 295f94b - Browse repository at this point
Copy the full SHA 295f94bView commit details
Commits on Jun 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4bae8c9 - Browse repository at this point
Copy the full SHA 4bae8c9View commit details
Commits on Jul 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for eee657b - Browse repository at this point
Copy the full SHA eee657bView commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4471139 - Browse repository at this point
Copy the full SHA 4471139View commit details
Commits on May 3, 2023
-
verified the UIA mappings with help from @benbeaudry made some of the wording consistent between mappings added in a SHOULD to indicate that if a figure is explicitly provided an accessible name from its figcaption, then do not expose the details relationship, as that'd add redundancy.
Configuration menu - View commit details
-
Copy full SHA for a8a4c01 - Browse repository at this point
Copy the full SHA a8a4c01View commit details -
Configuration menu - View commit details
-
Copy full SHA for f22b76b - Browse repository at this point
Copy the full SHA f22b76bView commit details -
saying it doesn't know what accname is... so, replacing the instances of the links which may be causing the issue?
Configuration menu - View commit details
-
Copy full SHA for 1108f16 - Browse repository at this point
Copy the full SHA 1108f16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fa6be7 - Browse repository at this point
Copy the full SHA 6fa6be7View commit details -
Configuration menu - View commit details
-
Copy full SHA for db3e5b7 - Browse repository at this point
Copy the full SHA db3e5b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82af13a - Browse repository at this point
Copy the full SHA 82af13aView commit details
Commits on Jun 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3fd830d - Browse repository at this point
Copy the full SHA 3fd830dView commit details -
add comment regarding aria-details
see https://bugs.chromium.org/p/chromium/issues/detail?id=1426613#c4 aria-details with an empty string could be useful to authors if there was a specific need to _not_ expose a child figcaption - e.g., if the elements need to have remapped roles for whatever reason.
Configuration menu - View commit details
-
Copy full SHA for 2339df0 - Browse repository at this point
Copy the full SHA 2339df0View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7263462 - Browse repository at this point
Copy the full SHA 7263462View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7839c03 - Browse repository at this point
Copy the full SHA 7839c03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a81370 - Browse repository at this point
Copy the full SHA 9a81370View commit details
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2380d76 - Browse repository at this point
Copy the full SHA 2380d76View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.