Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for jpms by remove use of ResourceBundle.Control #1544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aanno
Copy link

@aanno aanno commented Sep 5, 2023

I observed the following

  1. The use of ResourceBundle.Control with the Java Platform Module System (jpms) is not possible. In Java >=9 the following method is present in ResourceBundle:
     private static void checkNamedModule(Class<?> caller) {
         if (caller.getModule().isNamed()) {
             throw new UnsupportedOperationException("ResourceBundle.Control not supported in named modules");
         }
     }
  2. ResourceBundle *.properties files in epubcheck are UTF-8 encoded.

Hence this pull request will (a) eliminate the use of ResourceBundle.Control and unify the loading of *.properties files to enhance the compatibility of epubcheck with jpms.

Review und comments are appreciated.

Kind regards,

aanno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant