Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-aam] add new AX API mappings for colindextext/rowindextext #2362

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Oct 25, 2024

Closes w3c/core-aam#53

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests: n/a
  • "user agent MUST" tests:
    • not testable in WPT, so n/a
    • @spectranaut may wish to add platform mapping tests
  • Browser implementations (link to issue or commit):
  • Does this Mac-specific change need AT implementation?
    • VoiceOver change is not prioritized b/c there is not a platform equivalent
  • Related APG Issue/PR: n/a
  • MDN Issue/PR: n/a

@cookiecrook cookiecrook self-assigned this Oct 25, 2024
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 8b86586
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/673342bda62fc60008b9af31
😎 Deploy Preview https://deploy-preview-2362--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cookiecrook cookiecrook removed their assignment Oct 25, 2024
@cookiecrook
Copy link
Contributor Author

@twilco @minorninth FYI

@cookiecrook cookiecrook added the 1.3-Blocking Blocking issues for 1.3 WRWD label Oct 25, 2024
@cookiecrook cookiecrook changed the title add new AX API mappings for colindextext/rowindextext [core-aam] add new AX API mappings for colindextext/rowindextext Oct 25, 2024
core-aam/index.html Outdated Show resolved Hide resolved
core-aam/index.html Outdated Show resolved Hide resolved
discussed whether we should double-down on having "ARIA" in the property name just because that was added to the related AXARIAColumnIndex property.... We may deprecate the ARIA-specific names in the future
@jnurthen
Copy link
Member

jnurthen commented Nov 7, 2024

@aleventhal @jcsteh @spectranaut We'd like to merge this before the CR snapshot - can we get this reviewed as soon as possible please. Thanks.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookiecrook it seems like this new mapping is not implemented in any other the browsers, from a quick code search?

I added the implementation tracking, because it seems like we should be doing implementation tracking for this CL. Before it lands we should have issues on the browsers to implement.

Because this still needs implementation, should it really block the CORE-AAM snapshot? Perhaps if you really want it in, we can at least make issues on the browsers before merging.

@aleventhal
Copy link
Contributor

Funny you mention that, I'm working on a CL for it -- doesn't work yet:
https://chromium-review.googlesource.com/c/chromium/src/+/6012688

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Nov 13, 2024

doesn't work yet

Yes, it's new. So that ARIA WG doesn't have to publish a "TBD" in the spec.

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Nov 13, 2024

should it really block the CORE-AAM snapshot?

Otherwise I would expect it to be pulled or marked as At-Risk because this is a new feature without AT support on one platform, and without preceding vendor commitment. I outlined the concerns at:

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Nov 13, 2024

Perhaps if you really want it in, we can at least make issues on the browsers before merging.

I have linked the WebKit tracker and the one Aaron filed for Blink. I hesitate to file one for Gecko without acknowledgement from @jcsteh or @nmlapre that they want to do the mapping work before there is AT commitment.

@spectranaut
Copy link
Contributor

I have linked the WebKit tracker and the one Aaron filed for Blink. I hesitate to file one for Gecko without acknowledgement from @jcsteh or @nmlapre that they want to do the mapping work before there is AT commitment.

Sometimes I open issues on gecko and link back to the ARIA PR when I want to get review from firefox :) Personally I think it's fine to open an issue in this case, I don't think this change is controversial and besides it is coming from the API maintainers of AX API.

@spectranaut
Copy link
Contributor

Discussed in today's ARIA working group meeting: https://www.w3.org/2024/11/14-aria-minutes.html#8070

We will add this to the AAM, and open issues on browsers, as eventually, probably, VoiceOver will do something with this value.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per working group discussion, merging.

@spectranaut spectranaut merged commit 83872bf into main Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3-Blocking Blocking issues for 1.3 WRWD spec:core-aam
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need mappings for aria-rowindextext and aria-colindextext
5 participants