-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-aam] add new AX API mappings for colindextext/rowindextext #2362
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@twilco @minorninth FYI |
discussed whether we should double-down on having "ARIA" in the property name just because that was added to the related AXARIAColumnIndex property.... We may deprecate the ARIA-specific names in the future
@aleventhal @jcsteh @spectranaut We'd like to merge this before the CR snapshot - can we get this reviewed as soon as possible please. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cookiecrook it seems like this new mapping is not implemented in any other the browsers, from a quick code search?
I added the implementation tracking, because it seems like we should be doing implementation tracking for this CL. Before it lands we should have issues on the browsers to implement.
Because this still needs implementation, should it really block the CORE-AAM snapshot? Perhaps if you really want it in, we can at least make issues on the browsers before merging.
Funny you mention that, I'm working on a CL for it -- doesn't work yet: |
Yes, it's new. So that ARIA WG doesn't have to publish a "TBD" in the spec. |
Otherwise I would expect it to be pulled or marked as At-Risk because this is a new feature without AT support on one platform, and without preceding vendor commitment. I outlined the concerns at: |
I have linked the WebKit tracker and the one Aaron filed for Blink. I hesitate to file one for Gecko without acknowledgement from @jcsteh or @nmlapre that they want to do the mapping work before there is AT commitment. |
Sometimes I open issues on gecko and link back to the ARIA PR when I want to get review from firefox :) Personally I think it's fine to open an issue in this case, I don't think this change is controversial and besides it is coming from the API maintainers of AX API. |
Discussed in today's ARIA working group meeting: https://www.w3.org/2024/11/14-aria-minutes.html#8070 We will add this to the AAM, and open issues on browsers, as eventually, probably, VoiceOver will do something with this value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per working group discussion, merging.
Closes w3c/core-aam#53
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.