Migrate date management from momentjs to dayjs #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
force-pushed
the
move-to-dayjs
branch
from
5c75f54
to
bc4deb8
Compare
…or "Open Test Page button"
This reverts commit d09df2f.
* Updating jest environment and babel configuration * Trying nodegit 18 to fix builds * New github config to fix builds * Cacheing nodegit and fixing failing tests * Upgrade lighthouse
howard-e
force-pushed
the
update-dependencies
branch
from
3b3543c
to
7f2c2b2
Compare
howard-e
force-pushed
the
move-to-dayjs
branch
from
bc4deb8
to
817bcdb
Compare
Fix fake data seeder
Remove nodegit dependency
* Update React * Revert "Update React" This reverts commit d09df2f. * Fix misspellings in the readme * Fix files affected by revert on source branch --------- Co-authored-by: Howard Edwards <[email protected]>
howard-e
force-pushed
the
move-to-dayjs
branch
from
be7adaa
to
7bdaae9
Compare
evmiguel
approved these changes
Feb 28, 2023
|
|
||
| const issuesResolver = async testPlanReport => { | ||
| if (!testPlanReport.candidateStatusReachedAt) return []; | ||
|
|
||
| const searchPrefix = `${testPlanReport.at.name} Feedback: "`; | ||
| const searchTestPlanVersionTitle = | ||
| testPlanReport.testPlanVersion.dataValues.title; | ||
| const searchTestPlanVersionDate = moment( | ||
| const searchTestPlanVersionDate = dayjs( |
There was a problem hiding this comment.
Non-blocking: Would it be better to use one of the util functions instead of dayjs directly?
There was a problem hiding this comment.
Which util functions are you referring to there?
There was a problem hiding this comment.
Looks like this is the same as convertDateToString
# Conflicts: # .github/workflows/runtest.yml # client/components/CandidateTests/CandidateTestPlanRun/index.jsx # client/package.json # client/tests/TestQueue.test.jsx # client/utils/gitUtils.test.js # server/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to its size, mutability of the date objects, dropped support and more that can be found here, moving away from
momentwould be preferred at this time especially since it's footprint is small in the application.day.jswas found to be a widely accepted community alternative.