Support resources/ folder being moved on w3c/aria-at for tests import
#1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalgiag
approved these changes
Aug 29, 2024
| @@ -3,7 +3,7 @@ | |||
| const spawn = require('cross-spawn'); | |||
|
|
|||
| const ariaAtRepo = 'https://github.com/w3c/aria-at.git'; | |||
| const ariaAtDefaultBranch = 'master'; | |||
| const ariaAtDefaultBranch = 'move-resources'; // TODO: Revert to 'master' before merging | |||
There was a problem hiding this comment.
Placing another reminder to change this before merging
There was a problem hiding this comment.
Or actually I realize now that this is using the aria-at branch that should make this build over here. Perhaps the issues with CI point to a larger issue with the paths?
There was a problem hiding this comment.
Also wondering that too. Will investigate
There was a problem hiding this comment.
It should be fixed now in 0a54560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting change for w3c/aria-at#1096.
Note: this should be merged at the time of the next production deployment.