cleanup issueCredentialOptions and VerifyOptions #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhraisha
changed the title
dlongley
reviewed
Mar 12, 2024
TallTed
reviewed
Mar 12, 2024
msporny
changed the base branch from
main
to
310-add-challenge-management-endpoint-to-verifying-apis
msporny
approved these changes
Mar 12, 2024
|
@mkhraisha the group reviewed this today, looks like it's on a good path, we're getting ready to merge 373, please re-base once that happens and we'll merge this one as well. Thank you for the PR! |
dlongley
approved these changes
Mar 15, 2024
wes-smith
force-pushed
the
310-add-challenge-management-endpoint-to-verifying-apis
branch
from
3589fb3
to
0f47ef8
Compare
|
Re-ping @mkhraisha, please re-base, we'd like to merge your PR. |
mkhraisha
force-pushed
the
318/cleanup_options
branch
from
455f3f3
to
7fa06a1
Compare
|
Rebased, hopefully this works now. |
Base automatically changed from
310-add-challenge-management-endpoint-to-verifying-apis
to
main
March 26, 2024 19:11
- add challenge creation endpoint - remove passing `options.challenge` and `options.domain` to incorrect endpoints
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
mkhraisha
force-pushed
the
318/cleanup_options
branch
from
7fa06a1
to
17613e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked off #373
tackles #318
Merge conflicts will be cleaned up once once #373 is merged in.
Challenge changes are not intended to be reviewed in this PR, but are remnants from forking off #373.
IssueCredentialOptionsto removecreated, and updates the exampleDeriveCredentialOptionsto addselectivePointersVerifyOptionsthis has now been split into:VerifyCredentialOptions: this currently only hasreturnCredentialwhich is based on what the current spec shows.VerifyPresentationOptions: this currently has the propertiesdomainandchallenge. The issue mentions addingproofPurpose, but I wasn't sure, iirc theproofPurposeof a presentation is alwaysauthentication. if that is not true happy to update the PR. The Spec also mentionsreturnCredentialas a possible option to this endpoint, I'm not sure if thats an error that should bereturnPresentationor it should just be excluded entirely, I erred on the side of exclusion.CreatePresentationOptions: intended to provide options when creating a presentation, similar question on theproofPurposefield.VerifyOptions.Preview | Diff
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
Preview (#Don't…) (<a href="https://pr-preview.s3.amazonaws.com/w3c-ccg/vc-api/pull/375.html#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
<a href="https://pr-preview.s3.amazonaws.com/w3c-ccg/vc-api/pull/375.html" title="Last updated on Mar 5" title="#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
#just…) (#2024) (Preview | Preview | #9:44…) (#2024) (Diff" title="#9:44 PM UTC (ebd12e1)">Diff">#9:44…) | Diff