Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add returnCredential option to VerifyOptions #366

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Add returnCredential option to VerifyOptions #366

merged 5 commits into from
Feb 27, 2024

Conversation

jrhender
Copy link
Contributor

@jrhender jrhender commented Feb 6, 2024 •
edited
Loading

PR to address #207

TODO:

  • Fix extra json that is showing up in index.html
  • Describe what "canonical form" means. clarified here: Verifier API should return verified VCs #207 (comment)
  • Mention that the parameter is optional
  • Add return examples -> decided not to add verifiedCredential to example as it is an optional parameter
  • Add the feature to the Verify Presentation presentation end point -> I think it is better to do this in a separate PR

TallTed
TallTed suggested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial, human facing, for clarity

components/VerifyOptions.yml Outdated Show resolved Hide resolved
@jrhender jrhender marked this pull request as ready for review February 27, 2024 20:08
@msporny
Copy link
Contributor

msporny commented Feb 27, 2024

Normative, multiple reviews (on the call), changes requested and made, no objections, merging.

@msporny msporny merged commit a88023c into main Feb 27, 2024
1 check passed
@msporny msporny deleted the 207-jrhender-return-verified-credentials branch February 27, 2024 20:13
@jrhender jrhender mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@msporny msporny msporny approved these changes

@mavarley mavarley Awaiting requested review from mavarley mavarley is a code owner

@mkhraisha mkhraisha Awaiting requested review from mkhraisha mkhraisha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhender @msporny @TallTed