forked from rhtconsulting/rhc-ose
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Neutron floating IP support for Issue rhtconsulting#195
Also addressed the following issues encountered while testing this PR: * It is possible for an instance to not have a floating IP for whatever reason (such as manually deallocating or releasing the IP), in this case SSH will not work to the instance so it will not be included in the host group to attempt subscription manager unregister, but will still be deleted * It is possible that an instance will have a volume created but not attached. In this case as a precautionary measure I am excluding these unattached volumes from the deletion in case this was intentionally detached to preserve data. We can further discuss if this should be a parameter to override instead or if we need to change this behavior. * Excluded instances in ERROR state as they will most likely not delete. We can discuss if this should be parameterized instead. * Changed default ansible_ssh_user to cloud-user in line with our images * Add check for and set_fact if Neutron is in use which is used by several tasks * Add count for ips and volumes to display since these may not always be the same as instance count * Enhance displayed warning/note message to include new counts * Add check for valid item when attempting to delete objects
- Loading branch information
Showing
1 changed file
with
118 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters