Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add MdiskMode to BareMetalCreate and BareMetalUpdate structs #310

Merged
merged 1 commit into from
May 28, 2024

Conversation

fjoenichols
Copy link
Contributor

Description

The mdisk_mode param for baremetal create and update was recently added to the vultr api.

This pull request will add the mdisk_mode param as a possible input for the BareMetalCreate and BareMetalUpdate structs.

@optik-aper optik-aper added the enhancement New feature or request label May 28, 2024
@optik-aper optik-aper self-requested a review May 28, 2024 21:18
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BareMetalServer struct should have this field as well, based on the the GET docs https://www.vultr.com/api/#tag/baremetal/operation/get-baremetal

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@optik-aper optik-aper merged commit d442cca into vultr:master May 28, 2024
6 checks passed
@optik-aper optik-aper mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants