Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Managed Database public/private hostnames #268

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

christhemorse
Copy link
Contributor

Description

We recently rolled out support for distinguishing between public and private hostnames for Managed Databases, in which the regular host field points to the private address of a service attached to a VPC network and the new public_host field will then provide the public address. This PR matches that API functionality for the Govultr library.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the enhancement New feature or request label Oct 23, 2023
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@optik-aper optik-aper merged commit ec41e34 into vultr:master Oct 23, 2023
6 checks passed
@christhemorse christhemorse deleted the dbaas-add-public-host branch October 23, 2023 15:57
@optik-aper optik-aper mentioned this pull request Oct 23, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants