chore: tweaks

eslint.config.js

@@ -115,6 +115,7 @@ export default vuepress(
         // FIXME: Fail positives
         'import/no-extraneous-dependencies': 'off',
         'no-underscore-dangle': 'off',
+        'no-labels': 'off',
       },
     },
     vue: {

plugins/analytics/plugin-umami-analytics/src/client/composables/useUmamiAnalytics.ts

@@ -27,8 +27,7 @@ export const useUmamiAnalytics = ({
   hostUrl,
 }: UmamiOptions): void => {
   // avoid duplicated import
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-  if (window.umami) return
+  if ('umami' in window) return
 
   const script = document.createElement('script')
   script.src = link!

plugins/blog/plugin-blog/src/node/category/getCategory.ts

@@ -88,8 +88,7 @@ export const getCategory = (
           const categories = getter(page)
 
           for (const category of categories) {
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-            if (!map[category]) {
+            if (!(category in map)) {
               const itemPath = getItemPath(category)
 
               if (itemPath) {

plugins/markdown/plugin-prismjs/src/node/loadLanguages.ts

@@ -5,8 +5,8 @@ import rawLoadLanguages from 'prismjs/components/index.js'
 rawLoadLanguages.silent = true
 
 export const loadLanguages = (languages: string[]): void => {
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-  const langsToLoad = languages.filter((item) => !Prism.languages[item])
+  const langsToLoad = languages.filter((item) => !(item in Prism.languages))
+
   if (langsToLoad.length) {
     rawLoadLanguages(langsToLoad)
   }

plugins/search/plugin-docsearch/src/client/utils/preconnectToAlgolia.ts

@@ -3,8 +3,9 @@
  */
 export const preconnectToAlgolia = (appId: string): void => {
   const id = 'algolia-preconnect'
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-  const rIC = window.requestIdleCallback || setTimeout
+  const rIC =
+    'requestIdleCallback' in window ? window.requestIdleCallback : setTimeout
+
   rIC(() => {
     if (document.head.querySelector(`#${id}`)) return
     const preconnect = document.createElement('link')

plugins/seo/plugin-sitemap/src/node/getInfo.ts

@@ -99,7 +99,7 @@ export const getSitemapInfos = (
 
         links = relatedLocales.map((localePrefix) => ({
           // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-          lang: locales[localePrefix]?.lang || 'en',
+          lang: locales[localePrefix]?.lang ?? 'en',
           url: `${base}${removeLeadingSlash(localePrefix)}${rootPath.substring(1)}`,
         }))
       }

plugins/tools/plugin-cache/src/node/renderCache.ts

@@ -72,8 +72,7 @@ export const renderCacheWithMemory = async (
 
     const key = hash(input)
 
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-    if (metadata[filepath] === key && cache[filepath]) {
+    if (metadata[filepath] === key && filepath in cache) {
       const cached = cache[filepath]
       Object.assign(env, cached.env)
       return cached.content

plugins/tools/plugin-redirect/src/client/composables/setupDevServerRedirect.ts

@@ -38,7 +38,7 @@ export const setupDevServerRedirect = (): void => {
     let matchedLocalePath: string | null = null
 
     // get matched locale
-    // eslint-disable-next-line no-labels, no-restricted-syntax
+    // eslint-disable-next-line no-restricted-syntax
     findLanguage: for (const lang of languages.value)
       for (const [localePath, langs] of redirectLocaleEntries)
         if (langs.includes(lang)) {
@@ -49,7 +49,6 @@ export const setupDevServerRedirect = (): void => {
             continue
 
           matchedLocalePath = localePath
-          // eslint-disable-next-line no-labels
           break findLanguage
         }
 

themes/theme-default/src/client/composables/useSidebarItems.ts

@@ -48,8 +48,7 @@ export const setupHeaders = (): void => {
     }
 
     headersRef.value = getHeaders({
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-      selector: [...new Array(6)]
+      selector: [...new Array<undefined>(6)]
         .map((_, i) => `.theme-default-content h${i + 1}`)
         .join(','),
       levels: [2, levels.value + 1],

tools/helper/src/client/utils/getHeaders.ts

@@ -54,7 +54,7 @@ export const resolveHeaders = (
 
   const res: MenuItem[] = []
 
-  // eslint-disable-next-line no-labels, no-restricted-syntax
+  // eslint-disable-next-line no-restricted-syntax
   outer: for (let i = 0; i < allowedHeaders.length; i++) {
     const cur = allowedHeaders[i]
     if (i === 0) {
@@ -64,7 +64,6 @@ export const resolveHeaders = (
         const prev = allowedHeaders[j]
         if (prev.level < cur.level) {
           ;(prev.children ??= []).push(cur)
-          // eslint-disable-next-line no-labels
           continue outer
         }
       }
@@ -76,7 +75,6 @@ export const resolveHeaders = (
 }
 
 const serializeHeader = (h: Element, ignore: string[] = []): string => {
-  // eslint-disable-next-line no-useless-assignment
   let text = ''
 
   if (ignore.length) {
@@ -128,8 +126,9 @@ export interface GetHeadersOptions {
 }
 
 export const getHeaders = ({
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-  selector = [...new Array(6)].map((_, i) => `#vp-content h${i + 1}`).join(','),
+  selector = [...new Array<undefined>(6)]
+    .map((_, i) => `#vp-content h${i + 1}`)
+    .join(','),
   levels = 2,
   ignore = [],
 }: GetHeadersOptions = {}): MenuItem[] => {

tools/vp-update/src/index.ts

@@ -21,7 +21,6 @@ cli
   .example('docs')
   .action(async (targetDir = ''): Promise<Error | void> => {
     console.log('Bumping deps...')
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     const dir = resolve(process.cwd(), targetDir)
     const packageJSON = resolve(dir, 'package.json')