fix: replace existing route in addRoute show warning msg #3519
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this merged. We currently have to use a fork to get the documented behavior, which is not ideal Tested this and can confirm it works as expected 👍 |
|
没有人 merge 吗？ |
rwaltenberg
suggested changes
Jul 29, 2021
| } | ||
| pathMap[record.path] = record |
There was a problem hiding this comment.
This is undocumented behavior. The documentation states that only if the route has a name and the name matches with an existing route, it should be overwritten.
|
Niubitli！！ |
|
VueJS please fix |
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: addRoute is not work when there is already route with same name. replaced existing route in addRoute and show warning msg