Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use getter instead of computed for route location #1916

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 5, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 86c6fe5
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/64a550c0c38fb5000836f087

@codecov-commenter
Copy link

Codecov Report

Merging #1916 (86c6fe5) into main (c5b1ea1) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1916   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          24       24           
  Lines        1117     1117           
  Branches      348      348           
=======================================
  Hits         1014     1014           
  Misses         63       63           
  Partials       40       40           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@posva posva changed the title pref: use getter instead of computed for route location perf: use getter instead of computed for route location Jul 5, 2023
@posva posva merged commit f1b839e into vuejs:main Jul 5, 2023
5 checks passed
@antfu antfu deleted the pref/computed branch July 5, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants