Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading slash in documentation for apache redirect rule #1561

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bonham
Copy link

@bonham bonham commented Sep 24, 2022

This PR is about a small glitch in the documentation about redirect rules when setting up with apache:

When deploying to a subfolder instead of root, the example from the documentation would not work since apache will redirect from /subfolder/something to /index.html instead of /subfolder/something to /subfolder/index.html

If the leading slash is removed as proposed, the example would work for both - deployment to root or to subfolder.

When deploying to a subfolder instead of root, the example would not work since apache will redirect from `/subfolder/something` to `/index.html` instead of `/subfolder/something` to `/subfolder/index.html`

If the trailing slash is removed as proposed, the example would work for both - deployment to root or to subfolder.
@netlify
Copy link

netlify bot commented Sep 24, 2022

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit 47f6647
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/665a27bed6613a0008545043
😎 Deploy Preview https://deploy-preview-1561--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@posva posva added docs Concerns the documentation content or the documentation website need-feedback Waiting for more information labels Sep 26, 2022
@bonham bonham changed the title Remove trailing slash in apache redirect rule Remove leading slash in apache redirect rule May 31, 2024
@bonham bonham changed the title Remove leading slash in apache redirect rule Remove leading slash in documentation for apache redirect rule May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Concerns the documentation content or the documentation website need-feedback Waiting for more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants