-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(language-core): prevent the generation of generics in JS #4836
Conversation
vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
commit: |
How about add a unit test |
I don't know how to check the type of it :) |
Added |
With this PR, the inferred type of a Both problems specified in the issue itself however are indeed fixed with this, thanks for your work :) |
This PR only prevents injecting generics in JS to avoid unexpected type inference. When you don't use generics,
|
… fix/issue-4826
LGTM, thanks! |
fix #4826