Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix build on windows #2493

Merged

Conversation

Lehoczky
Copy link
Contributor

Resolves #2492

This PR uses pathe instead of the built-in path module from Node.js to handle the different file separators between Windows and other operating systems.

I tested it, and works, it's only a draft because I'm not sure you want to add another dependency to the project, even if it is only a dev dependency.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
Looks good to me. If you think it's OK to merge, please remove the draft mark.

@Lehoczky Lehoczky marked this pull request as ready for review July 1, 2024 06:28
@ota-meshi ota-meshi merged commit bfc72a4 into vuejs:master Jul 1, 2024
18 checks passed
@Lehoczky Lehoczky deleted the docs/fix-vitepress-build-for-windows branch July 1, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: require is not a function when running npm run docs:watch locally
2 participants