Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add an example on how to use custom parser with flat config #2490

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

Lehoczky
Copy link
Contributor

Related to: #2448

📚 Description

This PR adds an example on how to use this plugin with TypeScript, which is a common use case.

📜 Notes

The getting started guide is getting a bit hard to follow with a lot of warnings, duplicated text for each configuration style. It might worth extracting the .eslintrc format to a different subpage like it is done in the official eslint docs.


::: code-group

```json [Legacy Config]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I think we'll avoid using the terms "Legacy Config" and "Flat Config" in our documentation.
Could you please change it to use .eslintrc and eslint.config.js instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! I saw the same naming convention elsewhere in the docs, I changed those too^^

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi enabled auto-merge (squash) June 30, 2024 23:51
@ota-meshi ota-meshi disabled auto-merge July 1, 2024 00:23
@ota-meshi ota-meshi merged commit 4f52734 into vuejs:master Jul 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants