-
-
Notifications
You must be signed in to change notification settings - Fork 665
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add prefer-use-template-ref rule
- Loading branch information
1 parent
8b877f7
commit 21dfb40
Showing
5 changed files
with
378 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
--- | ||
pageClass: rule-details | ||
sidebarDepth: 0 | ||
title: vue/prefer-use-template-ref | ||
description: require using `useTemplateRef` over `ref` for template refs | ||
--- | ||
|
||
# vue/prefer-use-template-ref | ||
|
||
> require using `useTemplateRef` over `ref` for template refs | ||
- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> _**This rule has not been released yet.**_ </badge> | ||
- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule. | ||
|
||
## :book: Rule Details | ||
|
||
Vue 3.5 introduced a new way of obtaining template refs via | ||
the [useTemplateRef()](https://vuejs.org/guide/essentials/template-refs.html#accessing-the-refs) API. | ||
|
||
This rule enforces using the new `useTemplateRef` function over `ref` for template refs. | ||
|
||
<eslint-code-block fix :rules="{'vue/prefer-use-template-ref': ['error']}"> | ||
|
||
```vue | ||
<template> | ||
<div ref="divRef"></div> | ||
<button ref="submitter">Submit</button> | ||
</template> | ||
<script> | ||
import { ref, useTemplateRef } from 'vue'; | ||
/* ✓ GOOD */ | ||
const divRef = useTemplateRef('divRef'); | ||
const div = useTemplateRef('divRef'); | ||
const loremIpsum = useTemplateRef('divRef'); | ||
const submitButton = useTemplateRef('submitter'); | ||
/* ✗ BAD */ | ||
const divRef = ref(); | ||
const submitter = ref(); | ||
</script> | ||
``` | ||
|
||
</eslint-code-block> | ||
|
||
## :wrench: Options | ||
|
||
Nothing. | ||
|
||
## :mag: Implementation | ||
|
||
- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/prefer-use-template-ref.js) | ||
- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/prefer-use-template-ref.js) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
/** | ||
* @author Thomasan1999 | ||
* See LICENSE file in root directory for full license. | ||
*/ | ||
'use strict' | ||
|
||
const utils = require('../utils') | ||
|
||
/** @type {import("eslint").Rule.RuleModule} */ | ||
module.exports = { | ||
meta: { | ||
type: 'suggestion', | ||
docs: { | ||
description: | ||
'require using `useTemplateRef` over `ref` for template refs', | ||
categories: undefined, | ||
url: 'https://eslint.vuejs.org/rules/prefer-use-template-ref.html' | ||
}, | ||
fixable: 'code', | ||
schema: [], | ||
messages: { | ||
preferUseTemplateRef: "Replace 'ref' with 'useTemplateRef'." | ||
} | ||
}, | ||
/** @param {RuleContext} context */ | ||
create(context) { | ||
/** @type Set<string> */ | ||
const templateRefs = new Set() | ||
|
||
/** | ||
* @typedef ScriptRef | ||
* @type {{node: Expression, ref: string}} | ||
*/ | ||
|
||
/** | ||
* @type ScriptRef[] */ | ||
const scriptRefs = [] | ||
|
||
return utils.compositingVisitors( | ||
utils.defineTemplateBodyVisitor( | ||
context, | ||
{ | ||
'VAttribute[directive=false]'(node) { | ||
if (node.key.name === 'ref' && node.value?.value) { | ||
templateRefs.add(node.value.value) | ||
} | ||
} | ||
}, | ||
{ | ||
VariableDeclarator(declarator) { | ||
// @ts-ignore | ||
if (declarator.init?.callee?.name !== 'ref') { | ||
return | ||
} | ||
|
||
scriptRefs.push({ | ||
node: declarator.init, | ||
// @ts-ignore | ||
ref: declarator.id.name | ||
}) | ||
} | ||
} | ||
), | ||
{ | ||
'Program:exit'() { | ||
for (const templateRef of templateRefs) { | ||
const scriptRef = scriptRefs.find( | ||
(scriptRef) => scriptRef.ref === templateRef | ||
) | ||
|
||
if (!scriptRef) { | ||
continue | ||
} | ||
|
||
context.report({ | ||
node: scriptRef.node, | ||
messageId: 'preferUseTemplateRef', | ||
fix(fixer) { | ||
return fixer.replaceText( | ||
scriptRef.node, | ||
`useTemplateRef('${scriptRef.ref}')` | ||
) | ||
} | ||
}) | ||
} | ||
} | ||
} | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,232 @@ | ||
/** | ||
* @author Thomasan1999 | ||
* See LICENSE file in root directory for full license. | ||
*/ | ||
'use strict' | ||
|
||
const RuleTester = require('../../eslint-compat').RuleTester | ||
const rule = require('../../../lib/rules/prefer-use-template-ref') | ||
|
||
const tester = new RuleTester({ | ||
languageOptions: { | ||
parser: require('vue-eslint-parser'), | ||
ecmaVersion: 2020, | ||
sourceType: 'module' | ||
} | ||
}) | ||
|
||
tester.run('prefer-use-template-ref', rule, { | ||
valid: [ | ||
{ | ||
filename: 'single-use-template-ref.vue', | ||
code: ` | ||
<template> | ||
<div ref="root" /> | ||
</template> | ||
<script> | ||
import { useTemplateRef } from 'vue'; | ||
const root = useTemplateRef('root'); | ||
</script> | ||
` | ||
}, | ||
{ | ||
filename: 'multiple-use-template-refs.vue', | ||
code: ` | ||
<template> | ||
<button ref="button">Content</button> | ||
<a href="" ref="link">Link</a> | ||
</template> | ||
<script> | ||
import { useTemplateRef } from 'vue'; | ||
const buttonRef = useTemplateRef('button'); | ||
const link = useTemplateRef('link'); | ||
</script> | ||
` | ||
}, | ||
{ | ||
filename: 'use-template-ref-in-block.vue', | ||
code: ` | ||
<template> | ||
<div> | ||
<ul> | ||
<li ref="firstListItem">Morning</li> | ||
<li>Afternoon</li> | ||
<li>Evening</li> | ||
</ul> | ||
</div> | ||
</template> | ||
<script> | ||
import { useTemplateRef } from 'vue'; | ||
function getFirstListItemElement() { | ||
const firstListItem = useTemplateRef('firstListItem'); | ||
} | ||
</script> | ||
` | ||
} | ||
], | ||
invalid: [ | ||
{ | ||
filename: 'single-ref.vue', | ||
code: ` | ||
<template> | ||
<div ref="root"/> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
const root = ref(); | ||
</script> | ||
`, | ||
output: ` | ||
<template> | ||
<div ref="root"/> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
const root = useTemplateRef('root'); | ||
</script> | ||
`, | ||
errors: [ | ||
{ | ||
messageId: 'preferUseTemplateRef', | ||
line: 9, | ||
column: 22 | ||
} | ||
] | ||
}, | ||
{ | ||
filename: 'one-ref-unused-in-script.vue', | ||
code: ` | ||
<template> | ||
<button ref="button">Content</button> | ||
<a href="" ref="link">Link</a> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
const buttonRef = ref(); | ||
const link = ref(); | ||
</script> | ||
`, | ||
output: ` | ||
<template> | ||
<button ref="button">Content</button> | ||
<a href="" ref="link">Link</a> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
const buttonRef = ref(); | ||
const link = useTemplateRef('link'); | ||
</script> | ||
`, | ||
errors: [ | ||
{ | ||
messageId: 'preferUseTemplateRef', | ||
line: 11, | ||
column: 22 | ||
} | ||
] | ||
}, | ||
{ | ||
filename: 'multiple-refs.vue', | ||
code: ` | ||
<template> | ||
<h1 ref="heading">Heading</h1> | ||
<a href="" ref="link">Link</a> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
const heading = ref(); | ||
const link = ref(); | ||
</script> | ||
`, | ||
output: ` | ||
<template> | ||
<h1 ref="heading">Heading</h1> | ||
<a href="" ref="link">Link</a> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
const heading = useTemplateRef('heading'); | ||
const link = useTemplateRef('link'); | ||
</script> | ||
`, | ||
errors: [ | ||
{ | ||
messageId: 'preferUseTemplateRef', | ||
line: 10, | ||
column: 25 | ||
}, | ||
{ | ||
messageId: 'preferUseTemplateRef', | ||
line: 11, | ||
column: 22 | ||
} | ||
] | ||
}, | ||
{ | ||
filename: 'ref-in-block.vue', | ||
code: ` | ||
<template> | ||
<div> | ||
<ul> | ||
<li ref="firstListItem">Morning</li> | ||
<li>Afternoon</li> | ||
<li>Evening</li> | ||
</ul> | ||
</div> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
function getFirstListItemElement() { | ||
const firstListItem = ref(); | ||
} | ||
</script> | ||
`, | ||
output: ` | ||
<template> | ||
<div> | ||
<ul> | ||
<li ref="firstListItem">Morning</li> | ||
<li>Afternoon</li> | ||
<li>Evening</li> | ||
</ul> | ||
</div> | ||
</template> | ||
<script> | ||
import { ref } from 'vue'; | ||
function getFirstListItemElement() { | ||
const firstListItem = useTemplateRef('firstListItem'); | ||
} | ||
</script> | ||
`, | ||
errors: [ | ||
{ | ||
messageId: 'preferUseTemplateRef', | ||
line: 16, | ||
column: 33 | ||
} | ||
] | ||
} | ||
] | ||
}) |