Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @vitest/eslint-plugin when using vitest #559

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

cexbrayat
Copy link
Member

Description

The plugin is now officillay recommended, so let's add it to the eslint config when selecting both eslint and vitest.

On top of #558

@cexbrayat cexbrayat requested a review from btea August 14, 2024 14:01
The commit adds a unit test for the eslint configurations and properly formats our tests.
@cexbrayat cexbrayat force-pushed the feat/eslint-plugin-vitest branch 2 times, most recently from 892cba1 to c158189 Compare August 14, 2024 14:09
The plugin is now officillay recommended, so let's add it to the eslint config when selecting both eslint and vitest.
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It is better for you to merge these three PRs in order.

@cexbrayat cexbrayat merged commit aea5c1b into vuejs:main Aug 14, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants